1664330 - CardDAV syncs at start-up even with automatic sync turned off

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

The first sync when starting up doesn't check the pref to see if it should happen or not.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1664330 - Don't sync CardDAV servers at start-up if automatic sync is turned off. r?mkmelin

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9175067 [details]
Bug 1664330 - Don't sync CardDAV servers at start-up if automatic sync is turned off. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): Problem introduced by bug 1660127, so that shouldn't be uplifted without this.
User impact if declined: User setting ignored.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9b73e98dea8d
Don't sync CardDAV servers at start-up if automatic sync is turned off. r=mkmelin DONTBUILD

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9175067 [details]
Bug 1664330 - Don't sync CardDAV servers at start-up if automatic sync is turned off. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.3.0:
https://hg.mozilla.org/releases/comm-esr78/rev/753b9ef53cc2