1664372 - Intermittent /css/css-values/ch-pseudo-recalc-on-font-load.html | ch in pseudo-element ::before should be recalculated after loading a web font - assert_approx_equals: expected 25 +/- 0.1 but got 15

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315405002&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZCpMEdBPTXqUTZBEWwtTvw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-09-11T04:42:53.384Z] 04:42:53 INFO - TEST-START | /css/css-values/ch-pseudo-recalc-on-font-load.html
[task 2020-09-11T04:42:53.384Z] 04:42:53 INFO - Closing window 72
[task 2020-09-11T04:42:53.489Z] 04:42:53 INFO - PID 1168 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-09-11T04:42:53.631Z] 04:42:53 INFO - PID 1168 | [2170, Unnamed thread 7f579fb5d5e0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202
[task 2020-09-11T04:42:53.633Z] 04:42:53 INFO - PID 1168 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmppzIc_x/runtests_leaks_1099.log
[task 2020-09-11T04:42:53.634Z] 04:42:53 INFO - PID 1168 | [2170, Unnamed thread 7f579fb5d5e0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202
[task 2020-09-11T04:42:53.636Z] 04:42:53 INFO - PID 1168 | [2170, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 246
[task 2020-09-11T04:42:53.760Z] 04:42:53 INFO - PID 1168 | [Child 2170, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp, line 626
[task 2020-09-11T04:42:54.027Z] 04:42:54 INFO - PID 1837 | [Parent 1837, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x7fa4fa7ee2e0 (http://mzl.la/1FuID0j).: file /builds/worker/checkouts/gecko/storage/mozStoragePrivateHelpers.cpp, line 113
[task 2020-09-11T04:42:54.468Z] 04:42:54 INFO - PID 1168 | [Child 1801, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-09-11T04:42:54.496Z] 04:42:54 INFO - PID 1168 | [Child 1801, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp, line 4286
[task 2020-09-11T04:42:54.595Z] 04:42:54 INFO -
[task 2020-09-11T04:42:54.597Z] 04:42:54 INFO - TEST-UNEXPECTED-FAIL | /css/css-values/ch-pseudo-recalc-on-font-load.html | ch in pseudo-element ::before should be recalculated after loading a web font - assert_approx_equals: expected 25 +/- 0.1 but got 15
[task 2020-09-11T04:42:54.598Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:75:31
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:73:23
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO -
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - TEST-UNEXPECTED-FAIL | /css/css-values/ch-pseudo-recalc-on-font-load.html | ch in pseudo-element ::after should be recalculated after loading a web font - assert_approx_equals: expected 25 +/- 0.1 but got 15
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:75:31
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:73:23
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO -
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - TEST-PASS | /css/css-values/ch-pseudo-recalc-on-font-load.html | ch in pseudo-element ::first-letter should be recalculated after loading a web font
[task 2020-09-11T04:42:54.599Z] 04:42:54 INFO - TEST-UNEXPECTED-FAIL | /css/css-values/ch-pseudo-recalc-on-font-load.html | ch in pseudo-element ::first-line should be recalculated after loading a web font - assert_approx_equals: expected 25 +/- 0.1 but got 15
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:75:31
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:73:23
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO -
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - TEST-UNEXPECTED-FAIL | /css/css-values/ch-pseudo-recalc-on-font-load.html | ch in pseudo-element ::marker should be recalculated after loading a web font - assert_approx_equals: expected 25 +/- 0.1 but got 15
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:75:31
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1977:25
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - @http://web-platform.test:8000/css/css-values/ch-pseudo-recalc-on-font-load.html:73:23
[task 2020-09-11T04:42:54.600Z] 04:42:54 INFO - TEST-OK | /css/css-values/ch-pseudo-recalc-on-font-load.html | took 1215ms

Comment 1

[Intermittent Failures Robot]

7 failures in 3410 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3
• autoland: 2
• try: 2

Platform breakdown:

• macosx1014-64-shippable: 1
• linux1804-64: 1
• linux1804-64-qr: 1
• macosx1014-64: 2
• linux1804-64-shippable-qr: 1
• windows7-32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-09-07&endday=2020-09-13&tree=all

Comment 2

[Intermittent Failures Robot]

2 failures in 4195 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• android-em-7-0-x86_64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-09-28&endday=2020-10-04&tree=all

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Do you know what revived this issue?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I think Jonathan made some recent changes to font loading that may have caused this?

Comment 5

[Intermittent Failures Robot]

29 failures in 4130 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 19
• try: 2
• mozilla-central: 8

Platform breakdown:

• macosx1014-64: 8
• linux1804-64-asan: 10
• linux1804-64: 4
• windows10-64-shippable: 1
• macosx1014-64-shippable: 1
• linux1804-64-ccov: 2
• windows10-64-qr: 1
• linux1804-64-shippable-qr: 1
• linux1804-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 6

[Razvan Maries]

There have been 44 total failures in the last 7 days: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-10-10&endday=2020-10-17&tree=trunk&bug=1664372

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318837122&repo=autoland&lineNumber=1936

Comment 7

[Intermittent Failures Robot]

44 failures in 3694 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

This is the #31 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 27
• mozilla-central: 14
• try: 3

Platform breakdown:

• linux1804-64: 9
• macosx1014-64: 9
• linux1804-64-asan: 12
• windows10-64: 1
• linux1804-64-qr: 2
• linux1804-64-shippable-qr: 2
• macosx1014-64-shippable: 4
• linux1804-64-ccov: 2
• windows10-64-qr: 2
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-10-12&endday=2020-10-18&tree=all

Comment 8

[Intermittent Failures Robot]

32 failures in 4230 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #37 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 10
• mozilla-central: 11
• try: 9
• mozilla-beta: 2

Platform breakdown:

• linux1804-64-asan: 4
• linux1804-32-shippable: 3
• linux1804-64: 5
• linux1804-64-shippable-qr: 8
• linux1804-64-qr: 3
• windows10-64: 4
• windows10-64-shippable: 1
• windows7-32-shippable: 1
• macosx1014-64: 1
• android-em-7-0-x86_64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-10-19&endday=2020-10-25&tree=all

Comment 9

[Intermittent Failures Robot]

14 failures in 4275 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• try: 3
• mozilla-beta: 3
• mozilla-central: 7

Platform breakdown:

• windows10-64: 1
• linux1804-64-qr: 5
• linux1804-64-asan: 2
• linux1804-64-shippable-qr: 3
• android-em-7-0-x86_64: 1
• android-em-7-0-x86_64-qr: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

This test is permaorange on Android when run under a simulated e10s-multi-by-default configuration. I cannot land e10s-multi without disabling this test on Android, or fixing the root cause. If I cannot land e10s-multi on Android, then we will not be ready for important Fission work. Can we please get somebody to take a look into this?

Comment 11

[Sean Voisen (:svoisen)]

Pinged jfkthame on Matrix; will take a look.

Comment 12

[Jonathan Kew [:jfkthame]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

I think Jonathan made some recent changes to font loading that may have caused this?

This doesn't seem to be a recent regression; the testcase is unreliable for me in local testing even if I go back to a much earlier release. I'll attach a simplified example that shows the flakiness in manual testing.

Comment 13

[Jonathan Kew [:jfkthame]]

Attachment: Simplified example

This is based on the wpt testcase, with the actual test code removed so it just loads the document and applies the custom font (Ahem).

When the font finishes loading, the test text should be resized based on the new ch unit, but I'm not seeing this happen on initial load (or Shift-Reload); but if I then reload the page, or force a reflow by zooming, the rendering corrects itself.

If I explicitly preload the font using

customFont.load().then(() => document.fonts.add(customFont));

then it renders correctly on initial load, but AFAICS this shouldn't be necessary.

So it appears that we're failing to recompute styles properly when the font-load completes.

Comment 14

[Jonathan Kew [:jfkthame]]

(In reply to Aaron Klotz [:aklotz] from comment #10)

This test is permaorange on Android when run under a simulated e10s-multi-by-default configuration. I cannot land e10s-multi without disabling this test on Android, or fixing the root cause. If I cannot land e10s-multi on Android, then we will not be ready for important Fission work. Can we please get somebody to take a look into this?

Given that we seem to have a pre-existing, non-Android-specific issue here, I think you should feel free to disable the test on Android if that'll unblock your other work.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Rather than disabling, marking it as [PASS, FAIL] on android would be preferable, so that we at least run the tests. I can poke at the invalidation issue a bit though.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1664372 - Fix font loading invalidation to account for metrics coming from the parent style. r=jfkthame,#style

We were only looking at the given frame's style, which is not
sufficient for this case.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Hah, I had a pending self-ni? to investigate this in bug 1614853...

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5d69a2e7396
Fix font loading invalidation to account for metrics coming from the parent style. r=jfkthame

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b5d69a2e7396

Comment 21

[Intermittent Failures Robot]

16 failures in 4128 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 3
• try: 7
• mozilla-beta: 1

Platform breakdown:

• windows7-32: 1
• linux1804-64-qr: 4
• linux1804-64-shippable-qr: 2
• windows10-64: 2
• windows7-32-shippable: 1
• android-em-7-0-x86_64-qr: 2
• android-em-7-0-x86_64: 2
• linux1804-64-asan: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1664372&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 22

[Intermittent Failures Robot]

3 failures in 4040 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 3

Platform breakdown:

• linux1804-64-shippable-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1664372&startday=2020-11-09&endday=2020-11-15&tree=all