1664413 - Printing doesn't use current session cookies when in private mode

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[paulo+mozilla]

Attachment: Screenshot 2020-09-11 at 10.51.22.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36

Steps to reproduce:

Trying to print a page which requires sessions cookies. The page contains images that also require session cookies to be rendered.

Actual results:

The page itself renders fine on the browser window, including its images, but the printing itself shows broken images. Web server logs shows that the request for the images do not send the session cookies.

This happens in private mode or when using the "Never member history" setting.

On Mac, it's enough to do a PDF preview of the print to reproduce the problem.

Expected results:

Session cookies should be sent for (image) requests when printing the content of the current window — even when using private mode.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Do you have a page where we could reproduce this by any chance? It'd be helpful.

To be clear, this works in non-private mode, right?

Comment 3

[paulo+mozilla]

Attachment: print-issue.tar.gz

I'm attaching some basic php files that can reproduce the issue on demand.

1. Unzip them in a folder on a machine with php
2. run php -S 127.0.0.1:8080
3. go to http://localhost:8080/1.php (in Private mode)
4. follow button to 2.php
5. try printing that page with the image. Image will be broken because session cookies are not sent.

Note: this can also be reproduced in non-private mode if "Never remember history" is being used.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks forma the test case! I'll poke.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Err, fail from my phone :)

Comment 6

[Emilio Cobos Álvarez (:emilio)]

For the record: I looked at this today and couldn't print the image even on a clean, non-private session, but turns out I get:

Uncaught Error: Call to undefined function imagecreatefromjpeg() in /home/emilio/Downloads/print-issue/3.php:4

So I'll see how to enable that php function somehow.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Hmm, I got around that, but I can print the image just fine in Nightly, but somehow not on release... Can you confirm it works for you as well using a build from nightly.mozilla.org?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Ok, so this had to break in bug 1648064, because before that we didn't have image requests done for printing at all.

But it is fixed in Nightly, and I bisected this as follows:

$ mozregression --bad 2020-07-23 --arg="-private-window" -a http://localhost:8080/1.php --find-fix

And I got this fix range:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2969f3de028f013d30ea20bfccc13670ef8e195f&tochange=3afa7dd98397977db72ea93ba1253a327a1dcbaf

Which points to bug 1636728. Which makes some amount of sense, because before that we were minting a whole browsing context for printing which didn't preserve the origin attributes (container, private browsing mode, etc...) from the original doc.

So I think the only thing left here is adding an automated test to make sure this doesn't break again... Given this only happened for actual print output this is not the most trivial thing to test, though...

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1648064

Comment 10

[paulo+mozilla]

FWIW, I can confirm that it works on nightly.

Do I understand correctly that 81.0, when released, will have this fixed?

Comment 11

[Jonathan Watt [:jwatt]]

(In reply to paulo+mozilla from comment #10)

Do I understand correctly that 81.0, when released, will have this fixed?

I believe so. Can you confirm whether this is fixed in v81 for you?

Comment 12

[paulo+mozilla]

Yes, I confirm it works as expected on v81.0 when using Private Window. Thanks for the fix/follow up.