Closed Bug 1664439 Opened 4 years ago Closed 4 years ago

Intermittent comm/mail/base/test/performance/browser_preferences_usage.js | toolkit.scrollbox.horizontalScrollDistance should be accessed at least 40 times. - 40 <= 38

Categories

(Thunderbird :: Preferences, defect, P5)

defect

Tracking

(thunderbird_esr78 unaffected, thunderbird81 unaffected)

RESOLVED FIXED
82 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird81 --- unaffected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

I guess the point is that if it shrinks enough one should adjust the max number, to avoid regressing again? But for the toolkit ones, not much we'll do either way.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9175179 - Flags: review?(geoff)

Comment on attachment 9175179 [details] [diff] [review]
bug1664439_perf_38_40.patch

This is fine. Zero would also be fine.

Attachment #9175179 - Flags: review?(geoff) → review+
Target Milestone: --- → 82 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d1ffffd30cb1
don't (pointlessly) require a pref to be accessed more than it is. r=darktrojan DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: