1664514 - Crashes when fetching local .url files on Windows with privacy.file_unique_origin off

Status: VERIFIED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: file-url-crash.zip

1. Set privacy.file_unique_origin value to false
2. Unzip the attachment
3. Open url-fetch.html and see it crashes

The failure comes from https://searchfox.org/mozilla-central/rev/5d45da52f2fa423c9f4505ede5d1a5c7d48163fc/netwerk/protocol/http/nsCORSListenerProxy.cpp#742, and line 740 seems to mistakenly checking a wrong pointer.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1664514 - Proper null checks in CORS/fetch r=valentin

Comment 2

[Kershaw Chang [:kershaw]]

Set this to S4 since this crash require setting privacy.file_unique_origin to false.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/633d2aa345a3
Proper null checks in CORS/fetch r=valentin,necko-reviewers

Comment 4

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 633d2aa345a3 (bug 1664514) fro crashtest failures at dom/fetch/tests/crashtests/1664514.html

Backout: https://hg.mozilla.org/integration/autoland/rev/7662564fa23b45f4591a324025e4e5e563251fc6

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=633d2aa345a363853b6c93f3e5e6730286eca970

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315640958&repo=autoland&lineNumber=5306

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20895edea1a7
Proper null checks in CORS/fetch r=valentin,necko-reviewers

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/20895edea1a7

Comment 7

[Cristian Fogel [:cfogel]]

Instant [tab]Crash on 81.0.1 with the attached TC/scenario on Windows10.
Verified with 82.0b7, page loaded and message displayed; no crashes or hangs occur.