Closed Bug 1664525 Opened 2 months ago Closed 2 months ago

Various rust-xpcom cleanups

Categories

(Core :: XPCOM, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(4 files)

I wrote the code in rust-xpcom quite a few years ago, and there are some small things which should be cleaned up and improved, such as moving the code to the 2018 edition.

Blocks: 1664526

Previously, this code used a &'static T in order to get the null pointer
optimization. Since the code was written, NonNull has been stabilized, and now
should be used instead.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb92dde5174
Part 1: Update various xpcom crates to rust2018, r=emilio
https://hg.mozilla.org/integration/autoland/rev/0ae119cb2577
Part 2: Use NonNull in xpcom RefPtr, r=emilio
https://hg.mozilla.org/integration/autoland/rev/921d87a47b67
Part 3: Improve errors produced by #[derive(xpcom)], r=emilio
https://hg.mozilla.org/integration/autoland/rev/738872e80917
Part 4: Various derive(xpcom) proc_macro style improvements, r=emilio
You need to log in before you can comment on or make changes to this bug.