1664527 - Show "No results in <result type>" result in local search modes

Status: RESOLVED INVALID

(Firefox :: Address Bar, enhancement, P2)

Description

[Harry Twyford]

Attachment: local1-120.jpg

We should show a "No results in <result type>" result in local search modes when there is a search string that doesn't match any results of that type. It is not a heuristic result since it is not selected. The attached UX drawing shows the result appearing alongside an autofill result. It's not clear if this should happen if the autofill result is for a bookmarked site; I asked for clarification.

Comment 1

[Harry Twyford]

(In reply to Harry Twyford [:harry] from comment #0)

It's not clear if this should happen if the autofill result is for a bookmarked site; I asked for clarification.

If the autofilled site is bookmarked, then we should show the bookmark icon on it and not show the No Results in Bookmarks result.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

EDIT: I think I misunderstood this, so let me rephrase.

From what I understand we show "no results" only when there's no result and no heuristic. Right?

(In reply to Harry Twyford [:harry] from comment #1)

If the autofilled site is bookmarked, then we should show the bookmark icon on it and not show the No Results in Bookmarks result.

This is not trivial, we autofill origins, but it's not given that the origin is bookmarked, we would autofill even if only one url into that origin is bookmarked. That is also why we never wanted to show the star on autofill results.

Comment 3

[Harry Twyford]

UX changed their minds on this so I'm marking this INVALID. We can reopen if we change course.