16646 - [DOGFOOD] Browser crashes after starting an application/zip download

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P1)

Description

[Mike Palczewski]

go to http://www.securityfocus.com click on free tools.  then click on one of the urls for one of the tools.  a new window will pop up and mozilla will crash shortly afterwards.  I'm using oct 17 linux mozilla nightly build.

here is the gdb of the core
#0  0x401f54e1 in __kill () from /lib/libc.so.6
#1  0x4014333e in __pthread_unlock (lock=0x8aa1798) at restart.h:21
#2  0x40140b5f in __pthread_mutex_unlock (mutex=0x8aa1788) at mutex.c:126
#3  0x4012599b in PR_Unlock () from /opt/package/libnspr3.so
#4  0x40744b5f in nsSocketTransport::AsyncWrite ()
   from /opt/package/components/libnecko.so
#5  0x40d7850e in nsHTTPChannel::Open ()
   from /opt/package/components/libnecko_http.so
#6  0x40d77b92 in nsHTTPChannel::AsyncRead ()
   from /opt/package/components/libnecko_http.so
#7  0x407800be in nsDocumentBindInfo::Bind ()
   from /opt/package/libraptorwebwidget.so
#8  0x4077f263 in nsDocLoaderImpl::LoadDocument ()
   from /opt/package/libraptorwebwidget.so
#9  0x40783ca5 in nsWebShell::DoLoadURL ()
   from /opt/package/libraptorwebwidget.so
#10 0x40783f93 in nsWebShell::LoadURI ()
   from /opt/package/libraptorwebwidget.so
#11 0x407845cf in nsWebShell::LoadURL ()
   from /opt/package/libraptorwebwidget.so
#12 0x407834f1 in nsWebShell::LoadURL ()
   from /opt/package/libraptorwebwidget.so
#13 0x4078557c in nsWebShell::HandleLinkClickEvent ()
#14 0x407850a5 in HandlePLEvent () from /opt/package/libraptorwebwidget.so
#15 0x40106b9f in PL_HandleEvent () from /opt/package/libplds3.so
#16 0x40106b16 in PL_ProcessPendingEvents () from /opt/package/libplds3.so
#17 0x400e7baf in nsEventQueueImpl::ProcessPendingEvents ()
   from /opt/package/libxpcom.so
#18 0x403d8127 in event_processor_callback ()
   from /opt/package/libwidget_gtk.so
#19 0x4054b005 in gdk_io_invoke () from /usr/lib/libgdk-1.2.so.0
#20 0x40578c0f in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
#21 0x40579e43 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#22 0x4057a411 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#23 0x4057acc9 in g_main_run () from /usr/lib/libglib-1.2.so.0
#24 0x40497968 in gtk_main () from /usr/lib/libgtk-1.2.so.0
#25 0x403d8645 in nsAppShell::Run () from /opt/package/libwidget_gtk.so
#26 0x402df6e2 in nsAppShellService::Run () from /opt/package/libnsappshell.so
#27 0x804a4df in __register_frame_info () at ../../gcc/frame.c:581
#28 0x804a6ba in __register_frame_info () at ../../gcc/frame.c:581
#29 0x401ef1eb in __libc_start_main (
    main=0x804a5cc <__register_frame_info 4300>, argc=1, argv=0xbffffaf4,
    init=0x8049270 <_init>, fini=0x804bce8 <_fini>,
    rtld_fini=0x4000a610 <_dl_fini>, stack_end=0xbffffaec)
    at ../sysdeps/generic/libc-start.c:90

Comment 1

[Sean Richardson]

Also DOES NOT WORK CORRECTLY ON:
Windows NT 4.Osp3, mozilla.exe, 1999-10-17-08-M11

STEPS TO REPRODUCE:
Go to http://www.securityfocus.com
Click on free tools.
Then click on one of the urls for one of the tools.

ACTUAL RESULTS:
A new, legally cautionary confirm dialog will pop up. (Click OK)
Network activity will commence and continue for a duration that make sense
based on the file size.

EXPECTED RESULTS
A new, legally cautionary confirm dialog will pop up. (Click OK)
An "Unknown file type" dialog for application/zip will pop up,
or a "Save As" dialog box will pop up.

SPECULATION:
The crash in Linux and undesired network activity in NT are both caused
by the incompleteness of file-saving code. Adjusting Summary. Changing
Component to "XP File Handling"

Comment 2

[Warren Harris]

Looks like one for Rick.

Comment 3

[leger]

paulmac, I don't have linux here. can you try to reproduce please.

Comment 4

[Paul MacQuiddy]

I am hanging when I enter the above URL in the location bar and hit enter using
linux. Windows, a save as window comes up.

Comment 5

[Warren Harris]

We think that Wan-Teh checked in a fix for the nspr problem. Now the secondary
bug is the download issue. Off to Bill Law.

Comment 6

[don]

Hmmmm, I think we may need to fix this for M12.

Comment 7

[leger]

Are you saying that you cannot download a file?  If we cannot download a
file..yes...dogfood.  Please clarify the specific dogfood blocker here please.

Comment 8

[Paul MacQuiddy]

this is working for me now marking fixed, i think jud had some checkins, I was
able to download mozilla.tar.gz and unzip it and untar it!

using 12/01 build

Comment 9

[Eli Goldberg]

Bulk moving to XPCOM, in preparation for removal of XP File Handling component. 
(XPFH has received two bugs in ~5 months, and is no longer in active use.)