Closed Bug 1664918 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25525 - Revert "[blink] Fix top-level-await error reporting"

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25525 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25525
Details from upstream follow.

b'Avi Drissman <avi@chromium.org>' wrote:

Revert "[blink] Fix top-level-await error reporting"

This reverts commit 077d63da3268e6761d20c56409d37c57d37f1685.

Reason for revert:

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak

is constantly failing on

  • virtual/module-top-level-await/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-order-4-tla.html
  • virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html
  • virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-immediate-promise.html
  • virtual/module-top-level-await/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html

Original change's description:

[blink] Fix top-level-await error reporting

  • Enable tests with TLA enabled
  • Fix top-level error reporting with TLA

Based on the discussions on the spec, we fire error events on rejection
of the result promise:
https://github.com/whatwg/html/pull/4352#discussion_r435178136

Bug: 1022182, 1096455, 1127215, v8:9344
Change-Id: I16e83cb4e279c1e44be7fa70a51a103ee94aacc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228881
Commit-Queue: Camillo Bruni \<cbruni@chromium.org>
Reviewed-by: Hiroshige Hayashizaki \<hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno \<kouhei@chromium.org>
Reviewed-by: Dominic Farolino \<dom@chromium.org>
Reviewed-by: Domenic Denicola \<domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806593}

TBR=hiroshige@chromium.org,kouhei@chromium.org,cbruni@chromium.org,dom@chromium.org,domenic@chromium.org

Change-Id: I66b085b05ad30020772e80324e226275e41a8782
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1022182
Bug: 1096455
Bug: 1127215
Bug: v8:9344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410725
Reviewed-by: Avi Drissman \<avi@chromium.org>
Commit-Queue: Avi Drissman \<avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806724}

PR 25525 applied with additional changes from upstream: 88b098c19face9ae2c5f4268cac20af7019daf17
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 7
PASS : 6
FAIL : 1
TIMEOUT: 4

Chrome

OK : 7
PASS : 6
FAIL : 1
TIMEOUT: 4

Safari

OK : 7
FAIL : 7
TIMEOUT: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
document.write in an imported module: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
/html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html
document.write in an imported module: FAIL (Chrome: FAIL, Safari: FAIL)
/html/webappapis/dynamic-markup-insertion/document-write/module-tla-promise.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
document.write in an imported module: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7fbf6e582c62 [wpt PR 25525] - Revert "[blink] Fix top-level-await error reporting", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.