Find out why browser_togglePointerEventsNone.js fail with PiP toggle mode 2
Categories
(Toolkit :: Picture-in-Picture, task, P3)
Tracking
()
People
(Reporter: mconley, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [pip-needs-eng-triage])
According to my try pushes, these tests fail really frequently in this mode - though manual testing so far hasn't revealed that they're detecting user-facing problems, as least as far as I can tell. I've therefore temporarily disabled these tests as part of bug 1664899.
I'd like to figure out what's going on here so that we can re-enable these tests.
|
Reporter | |
Comment 1•4 years ago
|
||
Actually, it turns out that browser_mouseButtonVariation.js just needed a different target offset to click on given that the toggle is larger now, so that's been addressed.
browser_togglePointerEventsNone.js is weirder. It does look like if there's a pointer-events: none overlay on top of a <video>, and if the user right-clicks on the toggle in Mode 2, then we get mouse pointer events dispatched on the <body>.
I think this is not a problem. Right-clicking anywhere else on the video also produces the same events. It just seems that in the original toggle, those events were suppressed somehow.
Still, we should either ultimately fix this, or update the test somehow, so that we can re-enable it by default.
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
Description
•