1664949 - Themes stopped applying correctly in synced browser profiles

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[:Gijs (he/him)]

The code in bug 1660557 started clearing the extensions.activeThemeID pref when it shouldn't do that.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1660557

Comment 2

[:Gijs (he/him)]

Patch up in https://phabricator.services.mozilla.com/D90194 (not obvious while phabbugz is broken)

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1664949 - don't clear the active theme pref on startup so it gets synced wrong, r?zombie!,mixedpuppy!

Before bug 1660557, this was actually clearing an old migration pref, but now
it's clearing the actual theme pref used by Sync.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f1747588a69
don't clear the active theme pref on startup so it gets synced wrong, r=zombie,mixedpuppy

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for xpcshell failure on test_update_theme.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ad74c7002cfc6d2b9baccab0c07e58d077928573
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315784956&repo=autoland&lineNumber=5679

Comment 6

[:Gijs (he/him)]

From local logs:

pid:9556 console.log: "Shockwave FlashFlash plug-in for testing purposes." [is being installed]

Ceterum autem censeo Flash delendam esse

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6436125ed780
don't clear the active theme pref on startup so it gets synced wrong, r=zombie,mixedpuppy

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6436125ed780