1665002 - More vCard 2.1 attachments not handled properly

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

Attachment: test_mail_err-vcard.eml

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

First of all sorry for my English.
I believe that the problem mentioned in the bug 1659323 is still not solved.
As requested, I open a new bug.
My condition is:
Thunderbird 78.2.2 on Windows 7
Menu: View-> Show attachments online
Menu: View-> Message body as-> Original HTML

When I receive a message containing vCard attached, and I select the message in the error console I find this error:
uncaught exception: ParserError: Invalid parameters in 'adr;dom:;;MyAddress, XX;MyCity;MyPR;MyCAP'

I understood that the problem lies in the "; dom" part of the whole string above, but I don't know how to fix it.

It is also no longer possible to modify the vCard: the changes made are discarded when Thunderbird is reopened.

Sincerely thank you for the work you are doing

Comment 1

[Magnus Melin [:mkmelin]]

When referencing bugs, just write "bug" and the number. Like bug 1659323.

Comment 2

[aa4]

Thanks for the clarification, needless to add that everything is new to me

Comment 3

[aa4]

At the moment, I think not.
Thank you

Comment 4

[Geoff Lankow (:darktrojan)]

Strictly speaking it is fixed, you've just found another broken case. That said, I think I might take a different approach that would cover both cases and hopefully a lot more.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1665002 - Fix more edge cases parsing vCard 2.1. r?mkmelin

Instead of converting unknown tokens to something we can parse, just ignore them since we'll do that later on anyway.

Comment 6

[aa4]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

Strictly speaking it is fixed, you've just found another broken case. That said, I think I might take a different approach that would cover both cases and hopefully a lot more.

Thank you.
Yes, when you say "that would cover both cases and hopefully a lot more", I hope it too, because just this morning I found another new one:
"uncaught exception: ParserError: Invalid parameters in 'org;quoted-printable:MyCompany' "
I think the error is in "quoted-printable" part of the string.
...I promise you this is the last one that I report to you...

Comment 7

[Geoff Lankow (:darktrojan)]

I'm not sure that's even valid in vCard 2.1 (the absence of a proper spec doesn't help), but we might as well make it work while we're here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/69a9c07d411f
Fix more edge cases parsing vCard 2.1. r=mkmelin

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9175939 [details]
Bug 1665002 - Fix more edge cases parsing vCard 2.1. r?mkmelin

[Approval Request Comment]
User impact if declined: certain vCard 2.1 data will cause problems
Testing completed (on c-c, etc.): adds automatic test coverage

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9175939 [details]
Bug 1665002 - Fix more edge cases parsing vCard 2.1. r?mkmelin

[Triage Comment]
Approved for esr78

Please check 78.3.2 when it comes out

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.2.3:
https://hg.mozilla.org/releases/comm-esr78/rev/276ced5de266

Comment 12

[aa4]

(In reply to Wayne Mery (:wsmwk) from comment #10)

Comment on attachment 9175939 [details]
Bug 1665002 - Fix more edge cases parsing vCard 2.1. r?mkmelin

[Triage Comment]
Approved for esr78

Please check 78.3.2 when it comes out

Just installed TB 78.3.2 and everything works, certainly as far as I have reported above.
Thanks to everyone, also for the support