Closed Bug 1665019 Opened 4 years ago Closed 4 years ago

Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant code to use it

Categories

(Core :: Storage: Quota Manager, task, P2)

Product:
Core
Component:
Storage: Quota Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(1 file)

Bug 1665019 - Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant code to use it; r=#dom-workers-and-storage-reviewers
47 bytes, text/x-phabricator-request
Details | Review

This was raised in https://phabricator.services.mozilla.com/D89897

Sometimes in a debug only code we want to immediately assert that tryResult is ok.

Summary: Add QM_TRY_ASSERT/QM_TRY_VAR_ASSERT and quota client specific equivalents → Add QM_ASSERT_TRY/QM_ASSERT_TRY_VAR/QM_ASSERT_RETURN and quota client specific equivalents
Attachment #9176225 - Attachment description: Bug 1665019 - Add QM_ASSERT_TRY/QM_ASSERT_TRY_VAR/QM_ASSERT_RETURN and quota client specific equivalents; r=#dom-workers-and-storage → Bug 1665019 - Add QM_ASSERT_TRY/QM_ASSERT_TRY_VAR/QM_ASSERT_RETURN and quota client specific equivalents; r=#dom-workers-and-storage-reviewers
Summary: Add QM_ASSERT_TRY/QM_ASSERT_TRY_VAR/QM_ASSERT_RETURN and quota client specific equivalents → Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value
Attachment #9176225 - Attachment description: Bug 1665019 - Add QM_ASSERT_TRY/QM_ASSERT_TRY_VAR/QM_ASSERT_RETURN and quota client specific equivalents; r=#dom-workers-and-storage-reviewers → Bug 1665019 - Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value; r=#dom-workers-and-storage-reviewers
Summary: Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value → Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant uses of *_TRY*
Summary: Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant uses of *_TRY* → Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant code to use it
Attachment #9176225 - Attachment description: Bug 1665019 - Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value; r=#dom-workers-and-storage-reviewers → Bug 1665019 - Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant code to use it; r=#dom-workers-and-storage-reviewers
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/144fd47f3b40
Add QM_ASSERT_UNREACHABLE/QM_ASSERT_UNREACHABLE_VOID as a custom return value and convert relevant code to use it; r=dom-workers-and-storage-reviewers,sg

https://hg.mozilla.org/mozilla-central/rev/144fd47f3b40

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: