1665025 - After editing input-pill: Empty string passed to getElementById(). MsgComposeCommands.js:194:29

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1664733 +++

STR:

• edit an existing pill, press Enter

Actual

• console error: Empty string passed to getElementById(). MsgComposeCommands.js:194:29

Small flaw in the code, I'll fix this.

Comment 1

[Thomas D. (:thomas8)]

https://searchfox.org/comm-central/rev/67ff5d7aa78c03b51b1ccd06b8636f3ac28e5fbf/mail/components/compose/content/MsgComposeCommands.js#183-207

Comment 2

[Thomas D. (:thomas8)]

Attachment: 1665025_consoleErrorInputPill.diff

The fix: less code, no error.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9175707 [details] [diff] [review]
1665025_consoleErrorInputPill.diff

Review of attachment 9175707 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/MsgComposeCommands.js
@@ +188,5 @@
>          .wrappedJSObject;
>  
> +      // If no input proxy or it doesn't have an ID (in case of autocomplete
> +      // input of an existing pill), bail out.
> +      if (!input || !input.id) {

This is good, thanks for the update.
Let's make the comment a little bit more explicit for developers that never worked on pills.
Something like:
"Interrupt if we don't have an input proxy, or the input doesn't have an ID, meaning
the autocomplete event was triggered within an already existing pill, therefore we 
don't want to create another pill."

Comment 4

[Thomas D. (:thomas8)]

Attachment: 1665025_consoleErrorInputPill.diff

(In reply to Alessandro Castellani (:aleca) from comment #3)

Review of attachment 9175707 [details] [diff] [review] ⧉[details] [diff] [review]:
This is good, thanks for the update.
Let's make the comment a little bit more explicit for developers that never
worked on pills.

Lovely! So caring! ;-)

Comment 5

[Thomas D. (:thomas8)]

I guess we have more than enough errors in console, so one down and keeping the code in sync would qualify this for uplifting. More so as we'll certainly get lots of bugs claiming that pills don't work as expected, so having errors in this corner will be irritating for verifying such bugs. Very low risk, micro code rewrite.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fdbe71bbf50c
Fix console error "Empty string passed to getElementById()" when editing recipient pill. r=aleca

Comment 7

[Geoff Lankow (:darktrojan)]

You're too late for 80 and 81, and I think you probably meant to set flags on the attachment, not the bug.

Comment 8

[Magnus Melin [:mkmelin]]

Code cleanup, no real need to uplift.

Comment 9

[Rob Lemley [:rjl]]

Comment on attachment 9176341 [details] [diff] [review]
1665025_consoleErrorInputPill.diff

[Triage Comment]
As stated, this is minor code cleanup, but needed for uplifting bug 1668848.

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/1b458c23b743