Closed Bug 1665063 Opened 5 years ago Closed 5 years ago

Fix crash with parent session history in CanonicalBrowsingContext::HistoryCommitIndexAndLength()

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Fission Milestone M6b
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- disabled
firefox81 --- disabled
firefox82 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Keywords: crash)

Attachments

(1 file)

dom/html/test/browser_bug1081537.js crashes due to a null deref if you enable SessionHistoryInParent for fission.

I'm also wondering about CanonicalBrowsingContext::NotifyOnHistoryReload() and CanonicalBrowsingContext::RemoveDynEntriesFromActiveSessionHistoryEntry() in the same file...

Severity: -- → S2
Priority: -- → P2
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/autoland/rev/0438dfe8c6fd GetSessionHistory() isn't null-checked in HistoryCommitIndexAndLength() r=smaug
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: