Closed
Bug 1665150
Opened 3 years ago
Closed 3 years ago
maybeInstallBuiltinAddon should return a promise
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
83 Branch
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
Attachments
(1 file)
maybeInstallBuiltinAddon is documented to return a promise[1], however it does not return one[2]. It would simplify testing[3] at least if it returned the promise.
[1] https://searchfox.org/mozilla-central/rev/30e70f2fe80c97bfbfcd975e68538cefd7f58b2a/toolkit/mozapps/extensions/AddonManager.jsm#2551
[2] https://searchfox.org/mozilla-central/rev/30e70f2fe80c97bfbfcd975e68538cefd7f58b2a/toolkit/mozapps/extensions/internal/XPIProvider.jsm#2891-2900
[3] https://phabricator.services.mozilla.com/D90194
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → mixedpuppy
Severity: -- → S4
Priority: -- → P2
Assignee | ||
Comment 1•3 years ago
|
||
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/988b0844092b fix maybeInstallBuiltinAddon promise r=zombie
Comment 3•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•