1665172 - Clean up IOUtils

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task)

Description

[Beth Rennie [:beth] (she/her)]

There are a few minor cleanups to be done on the IOUtils code.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Remove ToMozPromise from IOUtils r?gijs,emalysz

This utility is not used and can be removed.

Depends on D95254

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::Read{,UT8}Sync for paths instead of strings r?gijs,emalysz

As part of cleaning up IOUtils, we can construct nsLocalFiles in
IOUtils::Read{,UTF8}, which has the benefit of doing more checks up front,
instead of waiting until we have passed work off to the background thread.

Once all methods pass nsIFile instances through to the background thread,
we can remove our own absolute path checking code.

Depends on D96134

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::WriteAtomic{,UT8}Sync for paths instead of strings r?gijs,emalysz

Some other clean ups have been made, like using nsIFile::Exists() instead of
opening a file to see if it exists.

Depends on D96135

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Add nsIFile::MoveToFollowingLinks{,Native} methods r?nika

Depends on D96136

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::{Copy,Move}Sync for paths instead of strings r?gijs,emalysz

We no longer normalize the paths in CopyOrMoveSync and instead rely on
nsIFile::{Copy,Move}ToFollowingLinks to provide path normalization.

Depends on D96137

Comment 6

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::RemoveSync for paths instead of strings r?gijs,emalysz

Depends on D96138

Comment 7

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::MakeDirectorySync for paths instead of strings r?gijs,emalysz

CreateDirectorySync has also been renamed to MakeDirectorySync to mirror
all other Fn vs FnSync methods in IOUtils.

Depends on D96139

Comment 8

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::StatSync for paths instead of strings r?gijs,emalysz

Depends on D96140

Comment 9

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::TouchSync for paths instead of strings r?gijs,emalysz

Depends on D96141

Comment 10

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Pass nsIFile through IOUtils::GetChildrenSync for paths instead of strings r?gijs,emalysz

Depends on D96142

Comment 11

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Use nsFileInputStream for IOUtils::ReadSync r?gijs,emalysz

nsFileInputStream does most of the same work we were doing manually to read
files and determine their size in ReadSync.

Depends on D96143

Comment 12

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Use nsCOMPtr for nsI* interface pointers r?gijs,emalysz

Depends on D96144

Comment 13

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - Use nsFileOutputStream for writing in IOUtils r?gijs,emalysz

The nsFileOutputStream does all the error checking we were doing in WriteSync,
which we can now remove. PR_CloseDelete and all usages of raw PR file
descriptors can be also now be removed.

Additionally, the mode we were using for writing included PR_WRONLY | PR_TRUNCATE | PR_APPEND, which makes the PR_APPEND redundant.

Depends on D96145

Comment 14

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1665172 - IOError::WithMessage should accept nsCString argument as const ref r?gijs,emalysz

Depends on D96146

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35729964b449
Remove ToMozPromise from IOUtils r=emalysz
https://hg.mozilla.org/integration/autoland/rev/6f67e1fdbb34
Pass nsIFile through IOUtils::Read{,UT8}Sync for paths instead of strings r=emalysz
https://hg.mozilla.org/integration/autoland/rev/6ca8089d00e3
Pass nsIFile through IOUtils::WriteAtomic{,UT8}Sync for paths instead of strings r=emalysz
https://hg.mozilla.org/integration/autoland/rev/c03cb8e8d84a
Add nsIFile::MoveToFollowingLinks{,Native} methods r=nika
https://hg.mozilla.org/integration/autoland/rev/9ce96274cd43
Pass nsIFile through IOUtils::{Copy,Move}Sync for paths instead of strings r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b8dd57b72a05
Pass nsIFile through IOUtils::RemoveSync for paths instead of strings r=emalysz
https://hg.mozilla.org/integration/autoland/rev/14a6de7d3adf
Pass nsIFile through IOUtils::MakeDirectorySync for paths instead of strings r=Gijs
https://hg.mozilla.org/integration/autoland/rev/caf75fed0764
Pass nsIFile through IOUtils::StatSync for paths instead of strings r=emalysz
https://hg.mozilla.org/integration/autoland/rev/be537370928e
Pass nsIFile through IOUtils::TouchSync for paths instead of strings r=emalysz
https://hg.mozilla.org/integration/autoland/rev/98e31bd40f8e
Pass nsIFile through IOUtils::GetChildrenSync for paths instead of strings r=Gijs
https://hg.mozilla.org/integration/autoland/rev/7eb3ffe23c14
Use nsFileInputStream for IOUtils::ReadSync r=Gijs
https://hg.mozilla.org/integration/autoland/rev/8f76a3bc1006
Use nsCOMPtr for nsI* interface pointers r=emalysz
https://hg.mozilla.org/integration/autoland/rev/e63cb11a9669
Use nsFileOutputStream for writing in IOUtils r=emalysz
https://hg.mozilla.org/integration/autoland/rev/8d8eeffbcdea
IOError::WithMessage should accept nsCString argument as const ref r=Gijs

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/35729964b449
https://hg.mozilla.org/mozilla-central/rev/6f67e1fdbb34
https://hg.mozilla.org/mozilla-central/rev/6ca8089d00e3
https://hg.mozilla.org/mozilla-central/rev/c03cb8e8d84a
https://hg.mozilla.org/mozilla-central/rev/9ce96274cd43
https://hg.mozilla.org/mozilla-central/rev/b8dd57b72a05
https://hg.mozilla.org/mozilla-central/rev/14a6de7d3adf
https://hg.mozilla.org/mozilla-central/rev/caf75fed0764
https://hg.mozilla.org/mozilla-central/rev/be537370928e
https://hg.mozilla.org/mozilla-central/rev/98e31bd40f8e
https://hg.mozilla.org/mozilla-central/rev/7eb3ffe23c14
https://hg.mozilla.org/mozilla-central/rev/8f76a3bc1006
https://hg.mozilla.org/mozilla-central/rev/e63cb11a9669
https://hg.mozilla.org/mozilla-central/rev/8d8eeffbcdea