Closed Bug 1665220 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 25555 - Add XR support to video.rVFC

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox83 fixed)

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25555 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25555
Details from upstream follow.

b'Thomas Guilbert <tguilbert@chromium.org>' wrote:

Add XR support to video.rVFC

Currently, when we enter an immersive XRSession, window.rAF calls stops,
which means we no longer deliver video.requestVideoFrameCallback calls.

This CL adds video.rVFC support to immersive XRSessions. If we find an
immersive XRSession, we schedule video.rVFC callbacks there instead of
the ScriptedAnimationController (SAC).

There can only be one immersive XRSession. If we don't find a session,
but we find that the XRFrameProvider exists, we request to be notified
when an immersive session start. This allows us to keep callbacks going
if the callbacks were already scheduled in the SAC when starting an
XRSession. Simmilarly, if the session ends when callbacks were pending
in the XRSession, we reschedule ourselves in the SAC.

Bug: 1107578
Change-Id: If0acf9445bb789bc848e0043908fc9b769cc5bdd
Reviewed-on: https://chromium-review.googlesource.com/2406522
WPT-Export-Revision: 1bce63a6d014195a89a1608720492e74337fd67d

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1
ERROR: 1

Chrome

OK : 2
PASS : 3

Safari

OK : 1
FAIL : 1
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/video-rvfc/request-video-frame-callback-before-xr-session.https.html: ERROR (Chrome: OK, Safari: ERROR)
/video-rvfc/request-video-frame-callback-during-xr-session.https.html
Make sure video.rVFC callbacks started during an immersive session continue after it ends: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc9c29a22cab [wpt PR 25555] - Add XR support to video.rVFC, a=testonly https://hg.mozilla.org/integration/autoland/rev/1971a4dbe6f9 [wpt PR 25555] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cc9c29a22cab
https://hg.mozilla.org/mozilla-central/rev/1971a4dbe6f9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.