1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Today, WebConsoleUI methods call WebConsoleWrapper methods once per resource:
https://searchfox.org/mozilla-central/source/devtools/client/webconsole/webconsole-ui.js#405

  _onResourceAvailable(resources) {
    for (const resource of resources) {
      [...]
      this.wrapper.dispatchMessageAdd(resource);
    }
  }

But this is bad for batching as it forces to do one action per resource.
Having said that, WebConsoleWrapper is doing some batching itself in order to mitigate that.
But with the new throttling done in bug 1663614 this will be made unecessary!

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665293 - Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated.

This will ultimately help get rid of throttling done in WebConsoleWrapper
in favor of the upcoming one to be done from ResourceWatcher.

Comment 2

[Alexandre Poirot [:ochameau]]

This patch has no impact on performance:
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=b48962d37e24d4708c08c253f02b0bf99be9065e&originalSignature=1910071&newSignature=1910071&framework=12&originalRevision=77aecf9a08978ae880c0ffb56bf83e4bbc583c65

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5055331a7b6e
Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out 3 changesets (Bug 1665306, Bug 1665305, Bug 1665293) for dt failures at browser_webconsole_network_attach.js.
https://hg.mozilla.org/integration/autoland/rev/cbedf38923ba0a5425ae5f36b82a797435b8a8e2

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=c966611ae0ad67660f64389416060a4fad060e4d&selectedTaskRun=MgOoT2k_QBmAZTayft9rgw.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316052586&repo=autoland&lineNumber=4101

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d587f427a634
Call WebConsoleWrapper methods only once from WebConsoleUI.onResourceAvailable/Updated. r=jdescottes

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d587f427a634