Closed Bug 1665302 Opened 4 years ago Closed 3 years ago

Intermittent devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_border.js | Should have the right value in the box model. - Got "3", expected "0"

Categories

(DevTools :: Inspector, defect, P5)

defect

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jdescottes)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=315813087&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PtuDzuk1TDiycZccEYctNA/runs/0/artifacts/public/logs/live_backing.log


[task 2020-09-16T08:46:48.754Z] 08:46:48     INFO - TEST-START | devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_border.js
[task 2020-09-16T08:46:51.525Z] 08:46:51     INFO - TEST-PASS | devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_border.js | Should have the right border - 
[task 2020-09-16T08:46:51.525Z] 08:46:51     INFO - Buffered messages finished
[task 2020-09-16T08:46:51.526Z] 08:46:51     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_border.js | Should have the right value in the box model. - Got "3", expected "0"
[task 2020-09-16T08:46:51.527Z] 08:46:51     INFO - Stack trace:
[task 2020-09-16T08:46:51.527Z] 08:46:51     INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-09-16T08:46:51.527Z] 08:46:51     INFO - chrome://mochitests/content/browser/devtools/client/inspector/boxmodel/test/browser_boxmodel_editablemodel_border.js:null:73
[task 2020-09-16T08:46:51.527Z] 08:46:51     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2020-09-16T08:46:51.527Z] 08:46:51     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1109
[task 2020-09-16T08:46:51.527Z] 08:46:51     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2020-09-16T08:46:51.528Z] 08:46:51     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1037
[task 2020-09-16T08:46:51.528Z] 08:46:51     INFO - Leaving test bound 
[task 2020-09-16T08:46:51.741Z] 08:46:51     INFO - Removing tab.
[task 2020-09-16T08:46:51.742Z] 08:46:51     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-09-16T08:46:51.763Z] 08:46:51     INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-09-16T08:46:51.791Z] 08:46:51     INFO - Tab removed and finished closing```

This bug failed 39 times in the last 7 days. Occurs on linux1804-64, linux1804-64-asan, windows10-64 on asan, opt and debug.

Recent log:
https://treeherder.mozilla.org/logviewer?job_id=328987820&repo=mozilla-central&lineNumber=4033

Julian: Can you please take a look at this bug?

Flags: needinfo?(jdescottes)
Whiteboard: [stockwell needswork:owner]

Boxmodel spans are rendered with react and might not be updated synchronously.

Not 100% sure but this might be triggered by a delay with react rendering. All the boxmodel tests seem to intermittently fail when asserting the text content of spans rendered with React.

Trying a patch that replaces the synchronous asserts with a helper based on waitUntil. We'll see if it fixes it.
Try at https://treeherder.mozilla.org/jobs?repo=try&revision=b4ec4f9b443277dc042983caba15e9e5b9aa9c1a&test_paths=devtools%2Fclient%2Finspector%2Fboxmodel%2Ftest

Flags: needinfo?(jdescottes)
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30a2d6eb61cb
[devtools] Wait for span text content in boxmodel tests r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

No new failure since the patch landed, looks like this was indeed an issue about tests not waiting for React rendering.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: