Closed Bug 1665350 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 25565 - Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness"

Categories

(Core :: MathML, task, P4)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25565 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25565
Details from upstream follow.

b'Fr\xc3\xa9d\xc3\xa9ric Wang <fwang@igalia.com>' wrote:

Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness"

This was reverted because the frac-1 test is failing on all windows platform
not just Win10.

Original change's description:

Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness"

This reverts commit d01e107517ff5b1da0544be36c5caaf30c27456e.

Reason for revert: \<breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29>

Original change's description:

[mathml] Use post.underlineThickness for the default fraction rulethickness

MathML Core currently defines fallback values to use when no MATH table
is available. This CL performs the remaining work to ensure fractions
align with the specification. It also adds WPT test to check these
fraction fallback parameters, although testing them extensively is
difficult.

Bug: 6606, 1058369
Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384
Commit-Queue: Frédéric Wang \<fwang@igalia.com>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807083}

TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com

Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 6606
Bug: 1058369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750
Reviewed-by: David Bienvenu \<davidbienvenu@google.com>
Commit-Queue: David Bienvenu \<davidbienvenu@google.com>
Cr-Commit-Position: refs/heads/master@{#807144}

Bug: 6606, 1058369
Change-Id: I2fefb18b84c9604fcd40a013617a51aeadf56602
Reviewed-on: https://chromium-review.googlesource.com/2414029
WPT-Export-Revision: fd08839158e1d16469de83c7f369b21b56877ce8

Component: web-platform-tests → MathML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 4 subtests

Status Summary

Firefox

OK : 3
PASS : 8[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] 10[Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub]
FAIL : 4[Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] 6[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview]
TIMEOUT: 3

Chrome

OK : 3
PASS : 10
FAIL : 4

Safari

OK : 3
PASS : 9
FAIL : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/mathml/presentation-markup/fractions/frac-1.html: OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], TIMEOUT [Gecko-linux1804-64-debug] (Chrome: OK, Safari: OK)
Vertical positions of numerator and denominator: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], PASS [Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: PASS)
/mathml/presentation-markup/scripts/underover-1.html: OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], TIMEOUT [Gecko-linux1804-64-debug] (Chrome: OK, Safari: OK)
Height of scripted elements: FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview], PASS [Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub] (Chrome: PASS, Safari: PASS)
/mathml/presentation-markup/fractions/frac-parameters-3.html: OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], TIMEOUT [Gecko-linux1804-64-debug] (Chrome: OK, Safari: OK)
nonzero linethickness, displaystyle=false: FAIL (Chrome: FAIL, Safari: FAIL)
nonzero linethickness, displaystyle=true: FAIL (Chrome: FAIL, Safari: FAIL)
linethickness=0, displaystyle=false: FAIL (Chrome: FAIL, Safari: FAIL)
linethickness=0, displaystyle=true: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b847cbbd892 [wpt PR 25565] - Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness", a=testonly https://hg.mozilla.org/integration/autoland/rev/3a3901613ac4 [wpt PR 25565] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.