1665373 - Remove nsCountedRef

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Emilio Cobos Álvarez [:emilio]]

It's just RefPtr

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1665373 - Stop using nsCountedRef in widget/gtk. r=stransky,karlt

Instead, use RefPtrTraits.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1665373 - Bail earlier if getting a null ref to NS_ReleaseOnMainThread. r=#xpcom-reviewers

This is just a minor optimization, not intended to change behavior.

Depends on D90397

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1665373 - Stop using nsCountedRef in the image container classes. r=aosmond

Instead, use NS_ReleaseOnMainThread. This requires exactly the same number of
special-cases, but let me know if you instead want a separate
MainThreadSurfaceRef which implements RefPtrTraits and releases on the main
thread or something...

Depends on D90398

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1665373 - Don't use nsAutoRef in fontconfig font list. r=jfkthame

There was a weird mix of nsAutoRef and nsCountedRef going on... Use RefPtr<>
for ref-counted things, and UniquePtr for non-refcounted ones.

Depends on D90399

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1665373 - Remove nsCountedRef. r=#xpcom-reviewers

It has no users after the previous patches.

Depends on D90400

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07558c195a1a
Bail earlier if getting a null ref to NS_ReleaseOnMainThread. r=sg

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a0e32a556c4
Stop using nsCountedRef in the image container classes. r=aosmond

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0376d4ca2a02
Don't use nsAutoRef in fontconfig font list. r=jfkthame

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/07558c195a1a
https://hg.mozilla.org/mozilla-central/rev/7a0e32a556c4
https://hg.mozilla.org/mozilla-central/rev/0376d4ca2a02

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8365c97a7534
Stop using nsCountedRef in widget/gtk. r=karlt
https://hg.mozilla.org/integration/autoland/rev/7cdb3eb59598
Remove nsCountedRef. r=xpcom-reviewers,nika

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8365c97a7534
https://hg.mozilla.org/mozilla-central/rev/7cdb3eb59598