Closed Bug 1665373 Opened 1 month ago Closed 1 month ago

Remove nsCountedRef

Categories

(Core :: XPCOM, task)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(5 files)

It's just RefPtr

This is just a minor optimization, not intended to change behavior.

Depends on D90397

Instead, use NS_ReleaseOnMainThread. This requires exactly the same number of
special-cases, but let me know if you instead want a separate
MainThreadSurfaceRef which implements RefPtrTraits and releases on the main
thread or something...

Depends on D90398

There was a weird mix of nsAutoRef and nsCountedRef going on... Use RefPtr<>
for ref-counted things, and UniquePtr for non-refcounted ones.

Depends on D90399

It has no users after the previous patches.

Depends on D90400

Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07558c195a1a
Bail earlier if getting a null ref to NS_ReleaseOnMainThread. r=sg
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a0e32a556c4
Stop using nsCountedRef in the image container classes. r=aosmond
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0376d4ca2a02
Don't use nsAutoRef in fontconfig font list. r=jfkthame
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8365c97a7534
Stop using nsCountedRef in widget/gtk. r=karlt
https://hg.mozilla.org/integration/autoland/rev/7cdb3eb59598
Remove nsCountedRef. r=xpcom-reviewers,nika
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.