1665420 - Remove BrowserId code and conditional prefs

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task, P1)

Description

[Vlad Filippov (:vladikoff)]

The 2 prefs that we have in the code right now[0], we should remove the conditional on those prefs and always default to the non-browserid path in the code.

In addition we should remove all the remaining browserid logic.

[0] - https://searchfox.org/mozilla-central/rev/30e70f2fe80c97bfbfcd975e68538cefd7f58b2a/browser/app/profile/firefox.js#1513

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: Bug 1665420 - Remove legacy BrowserID crypto code. r?markh

Comment 2

[Ryan Kelly [:rfkelly]]

I've made a start on this, and pushed a work-in-progress patch for visibility.

So far I am at 35 files changed, 197 insertions(+), 2408 deletions(-) and am pleased to see that Firefox appears to still sign in and sync and what-not correctly. Which is quite a relief since the code I'm deleting is supposedly dead!

The remaining work here is to update a bunch of tests that were doing browserid-specific things to have them do something else instead.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0836e1bb9cd
Remove legacy BrowserID crypto code. r=markh

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d0836e1bb9cd