1665442 - Show an "import" button on the bookmarks toolbar when few bookmarks exist [and some exist in another browser?]

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P2)

Description

[:Gijs (he/him)]

This should help people get their bookmarks into Firefox.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1665442 - cleanup in browser migration code while passing by, r?jaws

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1665442 - show an import button on the bookmarks toolbar for new profiles without bookmarks, r?jaws

Depends on D93617

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1665442 - make bookmark separators work on dark themes and improve macOS inactive styling for bookmark items

This also fixes bug 1311103 and bug 1617920.

Depends on D93618

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1665442 - remove the import button once the user successfully imports bookmarks, r?jaws

The caveat here is that this will not remove the item if the bookmarks migration had errors.
I think that is what we want at the moment, but this does mean that if we migrate 99
bookmarks successfully and have 1 error (e.g. an unrecognized URL), we will keep the button.

Depends on D93764

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef998400b1e1
cleanup in browser migration code while passing by, r=jaws
https://hg.mozilla.org/integration/autoland/rev/62ddd04d5498
show an import button on the bookmarks toolbar for new profiles without bookmarks, r=jaws,fluent-reviewers,flod,dao
https://hg.mozilla.org/integration/autoland/rev/a06c87566e51
make bookmark separators work on dark themes and improve macOS inactive styling for bookmark items r=dao
https://hg.mozilla.org/integration/autoland/rev/6b9978d2a957
remove the import button once the user successfully imports bookmarks, r=jaws

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ef998400b1e1
https://hg.mozilla.org/mozilla-central/rev/62ddd04d5498
https://hg.mozilla.org/mozilla-central/rev/a06c87566e51
https://hg.mozilla.org/mozilla-central/rev/6b9978d2a957

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

This is targeting 84.

Comment 9

[Florin Strugariu [:Bebe]]

== Change summary for alert #27400 (as of Wed, 28 Oct 2020 14:31:33 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	booking	Similarity2D	android-hw-g5-7-0-arm7-api-16-shippable	cold	0.96 -> 1.00
3%	booking	Similarity	android-hw-g5-7-0-arm7-api-16-shippable	cold	0.96 -> 0.98

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27400

Comment 10

[Mark Banner (:standard8)]

Florin, the changes here only affect desktop (all the changes are in browser/), so I think that performance improvement is attributed to the wrong bug.

Comment 11

[Florin Strugariu [:Bebe]]

after more digging through the graphs I think you are right.
sorry for the miss assignment

Comment 12

[Daniel Cicas [:dcicas], Release QA]

Hello,

Verified this issue on Fx 84.0b1 on Win 10, ubuntu and mac os.