Closed Bug 1665442 Opened 1 year ago Closed 11 months ago

Show an "import" button on the bookmarks toolbar when few bookmarks exist [and some exist in another browser?]

Categories

(Firefox :: Bookmarks & History, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox82 --- wontfix
firefox83 --- wontfix
firefox84 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [perftest:alert:0])

Attachments

(4 files)

This should help people get their bookmarks into Firefox.

Severity: -- → S3
Priority: -- → P2

The caveat here is that this will not remove the item if the bookmarks migration had errors.
I think that is what we want at the moment, but this does mean that if we migrate 99
bookmarks successfully and have 1 error (e.g. an unrecognized URL), we will keep the button.

Depends on D93764

Status: NEW → ASSIGNED
See Also: → 1672189
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ef998400b1e1
cleanup in browser migration code while passing by, r=jaws
https://hg.mozilla.org/integration/autoland/rev/62ddd04d5498
show an import button on the bookmarks toolbar for new profiles without bookmarks, r=jaws,fluent-reviewers,flod,dao
https://hg.mozilla.org/integration/autoland/rev/a06c87566e51
make bookmark separators work on dark themes and improve macOS inactive styling for bookmark items r=dao
https://hg.mozilla.org/integration/autoland/rev/6b9978d2a957
remove the import button once the user successfully imports bookmarks, r=jaws

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Blocks: 1311103
Blocks: 1617920

== Change summary for alert #27400 (as of Wed, 28 Oct 2020 14:31:33 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
4% booking Similarity2D android-hw-g5-7-0-arm7-api-16-shippable cold 0.96 -> 1.00
3% booking Similarity android-hw-g5-7-0-arm7-api-16-shippable cold 0.96 -> 0.98

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27400

Keywords: perf-alert

Florin, the changes here only affect desktop (all the changes are in browser/), so I think that performance improvement is attributed to the wrong bug.

Flags: needinfo?(fstrugariu)
Flags: needinfo?(fstrugariu)
Whiteboard: [perftest:alert:0]

after more digging through the graphs I think you are right.
sorry for the miss assignment

Hello,

Verified this issue on Fx 84.0b1 on Win 10, ubuntu and mac os.

Status: RESOLVED → VERIFIED
Blocks: 1678790
Regressions: 1679136
Depends on: 1680274
Regressions: 1679138
Regressions: 1681499
Regressions: 1681959
Depends on: 1685922
No longer regressions: 1690039
You need to log in before you can comment on or make changes to this bug.