Closed Bug 1665509 Opened 4 years ago Closed 4 years ago

|mach install-moz-phab| doesn't work on Windows

Categories

(Firefox Build System :: Mach Core, defect)

defect

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: mhentges, Assigned: mhentges)

References

Details

Attachments

(1 file)

Looks like moz-phab is being installed to the mach virtualenv, rather than to the calling environment.

$ ./mach install-moz-phab
 0:01.00 Installing moz-phab
Requirement already up-to-date: MozPhab in c:\users\mitch\.mozbuild\_virtualenvs\mach\lib\site-packages (0.1.90)
<snip>
WARNING: You are using pip version 19.3.1; however, version 20.2.3 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.

Mitch@DESKTOP-915TENP /c/dev/firefox
$ moz-phab
bash: /c/mozilla-build/python3/Scripts/moz-phab: No such file or directory
Assignee: nobody → mhentges
Blocks: 1665232
Status: NEW → ASSIGNED

On windows, just subprocessing pip3 ... was running the mach
virtualenv's pip3 binary, rather than the system's (or user's
virtualenv's) pip3.

Attachment #9176181 - Attachment description: Bug 1665509: Use shutil pip3 to install MozPhab in `install-moz-phab` → Bug 1665509: Use which(pip3) to install MozPhab in `install-moz-phab`
Pushed by mhentges@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0296368dce2b
Use which(pip3) to install MozPhab in `install-moz-phab` r=firefox-build-system-reviewers,rstewart
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: