1665709 - Use a unique resource listener from netmonitor in order to guarantee resource ordering

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1663614 is going to change slightly the implementation of ResourceWatcher and from now on, the resource order is only going to be guaranteed for a given Resource Listener.
i.e. two distinct calls to ResourceWatcher.watchResources will have their onAvailable/onUpdated method called in parallel with resource arrays, which will not guarantee the resource ordering as they may received mixed resource arrays depending on their watched resources.

At least the netmonitor is surfacing such issue where two dinstict calls to watchResources are being made while resource order is very important.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665709 - Use same listener for NETWORK_EVENT and NETWORK_EVENT_STACKTRACE in order to guarantee event order.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-reserve bugs for Fission Beta milestone (M7).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97e77b84546f
Use same listener for NETWORK_EVENT and NETWORK_EVENT_STACKTRACE in order to guarantee event order. r=bomsy

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/97e77b84546f

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1665709: don't update session history for about:blank transient pages r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1de39d201585
don't update session history for about:blank transient pages r=smaug

Comment 7

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=BIh3VkmbQ1ugAFQ1h6eaDg.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2Ccross%2Ccompiled%2Copt%2Cbuild-macosx64%2Fopt%2Cb&revision=1de39d2015857c7e92ea7b0a7d1cfee26646aef1

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316382108&repo=autoland&lineNumber=8065

Backout: https://hg.mozilla.org/integration/autoland/rev/429360ccbfdb78cf1a46e6b03f716727b1899316

Comment 8

[Alexandre Poirot [:ochameau]]

Randell, you probably attached this patch to the wrong bug?

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 9177119 [details]
Bug 1665709: don't update session history for about:blank transient pages r=smaug

wrong bug...