1665716 - Cleanup destroy method of Debugger's main.js module

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

This destroy method contains various cleanup that are probably meant to be down in sub component:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/main.js#28-32

See Julian's review comment:
https://phabricator.services.mozilla.com/D90427#inline-513228

followup: this destroy method is actually a bit wild :)
Apart from the "onDisconnect" that you added which mirrors perfectly the onConnect from "bootstrap", the rest of the content feels like it comes from nowhere. unmountRoot() and teardownWorkers() would fitt nicely in your new onDisconnect I think, because they mirror bootstrapApp and bootstrapWorkers (unmountRoot & bootstrapApp are on a slightly different level of abstraction, but I don't want to make things too complex).

For sourceQueue.clear() it's a bit weirder. The sourceQueue is initialized from setupEvents which is called in onConnect, so it could also make sense to have it in your disconnect?

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] Remove unused traits attribute passed around debugger frontend.

If we need trait, we can access it from the targetFront directly.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] initialize and destroy ReactDOM from the same module.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] initialize and destroy source queue from the same module.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] initialize and destroy debugger workers from the same module.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] Merge client/index.js into main.js.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] Get rid of unused connection object.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1665716 - [devtools] Listen to all resources only from one place in the debugger frontend.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b270b7095db3
[devtools] Remove unused traits attribute passed around debugger frontend. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c7649862f44f
[devtools] initialize and destroy ReactDOM from the same module. r=bomsy,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f50924deab4f
[devtools] initialize and destroy source queue from the same module. r=bomsy,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c94dcb558f2a
[devtools] initialize and destroy debugger workers from the same module. r=bomsy,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/949606f2079c
[devtools] Merge client/index.js into main.js. r=bomsy,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a9e0c9b685a4
[devtools] Get rid of unused connection object. r=bomsy,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/42133a1bb1e5
[devtools] Listen to all resources only from one place in the debugger frontend. r=bomsy,nchevobbe

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b270b7095db3
https://hg.mozilla.org/mozilla-central/rev/c7649862f44f
https://hg.mozilla.org/mozilla-central/rev/f50924deab4f
https://hg.mozilla.org/mozilla-central/rev/c94dcb558f2a
https://hg.mozilla.org/mozilla-central/rev/949606f2079c
https://hg.mozilla.org/mozilla-central/rev/a9e0c9b685a4
https://hg.mozilla.org/mozilla-central/rev/42133a1bb1e5