Closed Bug 1665749 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25603 - [LayoutShiftTracker] Fix contain:paint

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox83 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25603 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25603
Details from upstream follow.

b'Xianzhu Wang <wangxianzhu@chromium.org>' wrote:

[LayoutShiftTracker] Fix contain:paint

We should check ShouldClipOverflow() instead of IsScrollContainer()
(which was renamed from HasOverflowClip() recently -- this CL shows how
the new name improved code readability) for inclusion of layout overflow
for layout shift tracking.

Bug: 1127474
Change-Id: Id85b292b65dae837d1e366d548939b85c9cd5d5b

Reviewed-on: https://chromium-review.googlesource.com/2417061
WPT-Export-Revision: 95bdb80804a3c980ce3ee67c287b728a10d22821

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/contain-paint-fully-clipped.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
fully clipped by contain:paint: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/layout-instability/contain-paint-fully-clipped.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f72eeec0abd [wpt PR 25603] - [LayoutShiftTracker] Fix contain:paint, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.