Closed Bug 1665762 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25604 - Add tests to validate XR compatible request scenarios that should throw

Categories

(Core :: WebVR, task, P4)

Product:
Core
Component:
WebVR
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25604 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25604
Details from upstream follow.

b'Patrick To <patrto@microsoft.com>' wrote:

Add tests to validate XR compatible request scenarios that should throw

This change adds tests that validate scenarios where requesting XR
compatibility should fail:

  • If the WebXR feature policy isn't allowed, a SecurityError is thrown
  • If there are no devices available, an InvalidStateError is thrown

A runtime enabled feature is added for WebXR multi GPU that syncs with
the corresponding Chromium feature flag.

Bug: 1124024
Change-Id: Ia79b06ecffa936471a6fd80172717c7724245bf2
Reviewed-on: https://chromium-review.googlesource.com/2416856
WPT-Export-Revision: 4c00ef23945fbe0b495131ec1a4029dc6b18ea00

Component: web-platform-tests → WebVR
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
FAIL: 6

Chrome

OK : 2
PASS: 4
FAIL: 2

Safari

OK : 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webxr/webGLCanvasContext_create_xrcompatible.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: OK, Safari: OK)
Creating a webglCanvasContext with no device: FAIL (Chrome: FAIL, Safari: FAIL)
An XR-compatible webglCanvasContext can be created: FAIL (Chrome: PASS, Safari: FAIL)
/webxr/webxr_feature_policy.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: OK, Safari: OK)
Validate isSessionSupported behavior without xr-spatial-tracking policy: FAIL (Chrome: PASS, Safari: FAIL)
Validate requestSession behavior without xr-spatial-tracking policy: FAIL (Chrome: PASS, Safari: FAIL)
Validate devicechange event behavior without xr-spatial-tracking policy: FAIL (Chrome: PASS, Safari: FAIL)
Validate xr compatibility requests without xr-spatial-tracking policy: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/webxr/webGLCanvasContext_create_xrcompatible.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: OK, Safari: OK)
/webxr/webxr_feature_policy.https.html: OK [Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cf04e44472a
[wpt PR 25604] - Add tests to validate XR compatible request scenarios that should throw, a=testonly
https://hg.mozilla.org/integration/autoland/rev/05e4b8b25b39
[wpt PR 25604] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2cf04e44472a
https://hg.mozilla.org/mozilla-central/rev/05e4b8b25b39

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.