1665802 - Directly migrate importable passwords without wizard for single profile

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

This behavior would only be for the experiment treatment branch and off by default and maintaining current wizard behavior for the control branch too.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1665802 - Directly migrate importable passwords without wizard for single profile r?sfoster

Share importable handling from LoginManagerParent and support directly migrating.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1fe3374ab97
Directly migrate importable passwords without wizard for single profile r=sfoster

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1666373, Bug 1665802) for causing gv-junit and xpcshell failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7b98b01d238e1581d109397b51ba3356568e6566

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=7b98b01d238e1581d109397b51ba3356568e6566&fromchange=be95f3d07de37271de47f5cab75698547c141cd0&selectedTaskRun=GsI8vMjKTpKGbfsSGCrSDQ.0

Failure logs:

• XPCShell:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316561017&repo=autoland&lineNumber=4531
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316559177&repo=autoland&lineNumber=1877
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316561072&repo=autoland&lineNumber=2199
• Geckoview:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316560087&repo=autoland&lineNumber=2235
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316559061&repo=autoland&lineNumber=2245

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8c79e44076d
Directly migrate importable passwords without wizard for single profile r=sfoster

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e8c79e44076d

Comment 6

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: The wizardless password import autocomplete experiment is scheduled for 82

QA steps: Note, this landed (and planning to uplift to 82) at the same time as bug 1666373 which means the direct migration without wizard functionality is only active in the treatment branch

Prerequisites:

• enrolled in "treatment" branch as per bug 1666373
• chrome/chromium/edge(chromium based) with a single profile with saved login
• no saved login in firefox for the site that does have saved in the other browser
• signon.suggestImportCount pref is greater than 0 (e.g., default 3)

1. navigate to site with saved login in other browser
2. focus username or password field
3. select the import suggestion

Expect: no migration wizard is shown and popup now shows the imported login

For "control" branch as well as not enrolled in the experiment, the behavior is to show the wizard as in 81. If the browser-to-import-from has multiple profiles, the wizard will also be shown even when in "treatment."

Comment 7

[Julien Cristau [:jcristau]]

I don't think I need to track this.

Comment 8

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Marking this as Verified based on the verification done in bug 1666373.

Comment 9

[Ed Lee :Mardak]

Comment on attachment 9176433 [details]
Bug 1665802 - Directly migrate importable passwords without wizard for single profile r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Users need to go through the full import wizard flow instead of direct migration
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 6
• List of other uplifts needed: Bug 1666850, Bug 1666373
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The functionality will be default off, and bug 1666373 is needed to turn on this feature for those in the experiment, and bug 1666850 is needed to get the experiment working for new profiles.

The code touches the password import autocomplete suggestions which only show up for new users who have importable passwords.

• String changes made/needed: None

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9176433 [details]
Bug 1665802 - Directly migrate importable passwords without wizard for single profile r?sfoster

approved for 82.0b6

Comment 11

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0090eb086dd2

Comment 12

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Marking this as Verified based on the verification done in bug 1666373.