Remove support for Result<V, E&>
Categories
(Core :: MFBT, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox83 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(3 files)
Resutl<V, E&>
i.e. a Result with a reference error type is only used in one context. It adds some complexity to the Result implementation, and there might be alternatives to that.
See also https://phabricator.services.mozilla.com/D90561#2891119
Assignee | ||
Comment 1•4 years ago
|
||
Also switch existing tests.
Depends on D90561
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D90661
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
It was necessary earlier because the include for ResultExtensions.h was missing.
Depends on D90662
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5bc547e7a773 Switch JS to use non-reference errors with mozilla::Result. r=jandem https://hg.mozilla.org/integration/autoland/rev/5e23340e3b39 Remove specifics for reference error types from mozilla::Result. r=emilio,jandem https://hg.mozilla.org/integration/autoland/rev/ebd4dfbc0a88 Remove workaround in RestartBulkWrite that's no longer necessary. r=xpcom-reviewers,nika
Comment 5•4 years ago
•
|
||
Backed out for causing bustage on Result.h.
Backout link: https://hg.mozilla.org/integration/autoland/rev/32d03662a363850006f648c22e825b3e886b29bc
Failure log : https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316240410&repo=autoland&lineNumber=79127
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db58462a8866 Switch JS to use non-reference errors with mozilla::Result. r=jandem https://hg.mozilla.org/integration/autoland/rev/20263215e165 Remove specifics for reference error types from mozilla::Result. r=emilio,jandem https://hg.mozilla.org/integration/autoland/rev/f469093eb17b Remove workaround in RestartBulkWrite that's no longer necessary. r=xpcom-reviewers,nika
Comment 7•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/db58462a8866
https://hg.mozilla.org/mozilla-central/rev/20263215e165
https://hg.mozilla.org/mozilla-central/rev/f469093eb17b
Description
•