Closed Bug 1665850 Opened 4 years ago Closed 4 years ago

Remove support for Result<V, E&>

Categories

(Core :: MFBT, task)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox83 --- fixed

People

(Reporter: sg, Assigned: sg)

Details

Attachments

(3 files)

Resutl<V, E&> i.e. a Result with a reference error type is only used in one context. It adds some complexity to the Result implementation, and there might be alternatives to that.

See also https://phabricator.services.mozilla.com/D90561#2891119

Also switch existing tests.

Depends on D90561

Assignee: nobody → sgiesecke
Attachment #9176488 - Attachment description: Bug 1665850 - Switch JS to use non-reference errors with mozilla::Result. → Bug 1665850 - Switch JS to use non-reference errors with mozilla::Result. r=emilio,jandem
Status: NEW → ASSIGNED
Attachment #9176489 - Attachment description: Bug 1665850 - Remove specifics for reference error types from mozilla::Result. → Bug 1665850 - Remove specifics for reference error types from mozilla::Result. r=emilio

It was necessary earlier because the include for ResultExtensions.h was missing.

Depends on D90662

Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bc547e7a773
Switch JS to use non-reference errors with mozilla::Result. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5e23340e3b39
Remove specifics for reference error types from mozilla::Result. r=emilio,jandem
https://hg.mozilla.org/integration/autoland/rev/ebd4dfbc0a88
Remove workaround in RestartBulkWrite that's no longer necessary. r=xpcom-reviewers,nika
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db58462a8866
Switch JS to use non-reference errors with mozilla::Result. r=jandem
https://hg.mozilla.org/integration/autoland/rev/20263215e165
Remove specifics for reference error types from mozilla::Result. r=emilio,jandem
https://hg.mozilla.org/integration/autoland/rev/f469093eb17b
Remove workaround in RestartBulkWrite that's no longer necessary. r=xpcom-reviewers,nika
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: