1665903 - "security/test/general/test_same_site_cookies_toplevel_nav.html" calls non-existing method (typo)

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

https://searchfox.org/mozilla-central/rev/5efefd3ef214ed6d3234ba245c1da3004ead94e0/dom/security/test/general/file_same_site_cookies_toplevel_nav.sjs#27

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1665903: Fix typo in test_same_site_cookies_toplevel_nav. r=freddyb

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e00cc5ee99d4
Fix typo in test_same_site_cookies_toplevel_nav. r=freddyb

Comment 3

[:Gijs (he/him)]

So there was a typo along the lines of window.addEventListner (missing e) and this patch is fixing this.

Mark, how hard would it be to use our webidl definitions to warn about uses of window or document properties that aren't in the webidl files?

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e00cc5ee99d4

Comment 5

[Mark Banner (:standard8)]

(In reply to :Gijs (he/him) from comment #3)

So there was a typo along the lines of window.addEventListner (missing e) and this patch is fixing this.

Mark, how hard would it be to use our webidl definitions to warn about uses of window or document properties that aren't in the webidl files?

Feels like it might be possible, not sure how hard as we'd probably want something for processing the webidl files to give us that information if there isn't something already.