1665914 - Account for scenarios of Topsites experiment and Topsites Remote Settings integration

Status: RESOLVED FIXED

(Firefox :: Top Sites, task, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Taking in account the weekly search sync with Mike de Boer and additional brain storming with :cmuresan, it is very likely that the Topsites Experiment (https://experimenter.services.mozilla.com/experiments/topsites-url-redirect/ + https://experimenter.services.mozilla.com/experiments/topsites-url-redirect-germany/) and the turn on of the Topsites powered by Remote Settings will intersect (experiment rampdown and RS Topsites ramp up) and the scenarios combining the two are not covered anywhere at this moment.

Logging this to keep track that the above should be considered in order to ensure the transition betwen the two goes smoothly.

Comment 1

[Dão Gottwald [:dao]]

Worth verifying, but in theory this will "just work". The experiment turns search tiles into direct links, but we don't plan on using search tiles from remote settings, so at that point the experiment code wouldn't do anything.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1665914 - Ignore search tile override prefs when using top site defaults from remote settings. r=mikedeboer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8784af2caa8
Ignore search tile override prefs when using top site defaults from remote settings. r=mikedeboer

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f8784af2caa8

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9177353 [details]
Bug 1665914 - Ignore search tile override prefs when using top site defaults from remote settings. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: I'm told we might in fact use search tiles from remote settings in some regions, at which point this will become relevant.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed: