Closed Bug 1666010 Opened 9 months ago Closed 9 months ago

Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly

Categories

(Core :: DOM: Navigation, defect)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files)

I made a silly mistake when addressing review comments of bug 1574261.
Tiny patch coming.

The code in the original patch was
bool nsDocShell::IsLoadingFromSessionHistory() {
return mLoadingActiveEntry && mLoadingActiveEntry->mLoadIsFromSessionHistory;
}
(where mLoadingEntry was swapped to mLoadingActiveEntry)

And I made the bool just !!mLoadingEntry

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50574f2726b4
Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly r=nika
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1cd1bafb3b91
Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly r=peterv
You need to log in before you can comment on or make changes to this bug.