1666010 - Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

I made a silly mistake when addressing review comments of bug 1574261.
Tiny patch coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

The code in the original patch was
bool nsDocShell::IsLoadingFromSessionHistory() {
return mLoadingActiveEntry && mLoadingActiveEntry->mLoadIsFromSessionHistory;
}
(where mLoadingEntry was swapped to mLoadingActiveEntry)

And I made the bool just !!mLoadingEntry

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1666010 - Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50574f2726b4
Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly r=nika

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/50574f2726b4

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1666010 - Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly r=nika

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cd1bafb3b91
Ensure nsDocShell::mActiveEntryIsLoadingFromSessionHistory value is set correctly r=peterv

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1cd1bafb3b91