1666050 - Alignment and line height issue for every text element, including buttons, fields, descriptions, etc.

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect, P3)

Description

[Alessandro Castellani [:aleca]]

Attachment: comparison.png

This issue seems to happen only on macOS, but I haven't tested Windows.

It seems that all the elements using text aren't properly aligned anymore.
Every button, text field, description, or label is visually misaligned.

This issue doesn't affect 78.

Comment 1

[Richard Marti (:Paenglab)]

The today pane spacing comes from https://searchfox.org/comm-central/source/calendar/base/themes/common/widgets/calendar-widgets.css#25 changed in bug 1621135. Maybe you know the patch author. ;-)

The other things I think I don't see.

Comment 2

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: AlignmentTextButton.png

Tested on macOS, Firefox 85.0 on the extended bookmark dropdown the text are misaligned, not centered in Remove Bookmark (Cancel) and Done buttons.

Comment 3

[Alessandro Castellani [:aleca]]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #2)

Created attachment 9198594 [details]
AlignmentTextButton.png

Tested on macOS, Firefox 85.0 on the extended bookmark dropdown the text are misaligned, not centered in Remove Bookmark (Cancel) and Done buttons.

That seems to be a different issue only related to Firefox.
All the alignment issues in Thunderbird have been solved.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1666050-today-pane-items.diff

Taking care of the missing padding issue on the Today Pane just a bunch of months after I broke it...

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9200167 [details] [diff] [review]
1666050-today-pane-items.diff

Yeah, looks better.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be7e6bd4c4e3
Fix sizing of Today Pane agenda treechildren. r=Paenglab