Add xmlextras to embedding manifests

VERIFIED FIXED in mozilla1.0.2

Status

()

P1
critical
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: adamlock, Assigned: adamlock)

Tracking

({topembed+})

Trunk
mozilla1.0.2
topembed+
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2] [ETA 09/12])

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
Useful functionality for embedders to have
(Assignee)

Updated

17 years ago
Keywords: topembed+
(Assignee)

Comment 1

17 years ago
Created attachment 97783 [details] [diff] [review]
Patch to embedding manifests
(Assignee)

Comment 3

17 years ago
*** Bug 143342 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 4

17 years ago
Created attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

Can I have an r/sr on these simple patches?
(Assignee)

Comment 5

17 years ago
branch checkin approval, a=valeski@netscape.com
Keywords: edt1.0.2+

Updated

17 years ago
Keywords: mozilla1.2
Priority: -- → P1
Whiteboard: [adt2] [ETA 09/12]
Target Milestone: --- → mozilla1.0.2
(Assignee)

Comment 6

17 years ago
Heikki can you give me an sr on this so I can get it into the trunk?

The readme.html already has a note about how to remove components by writing a
client-win file, but I can add something that specifically mentions XMLExtras.
Priority: P1 → --
Target Milestone: mozilla1.0.2 → ---

Updated

17 years ago
Blocks: 154896
Keywords: approval, mozilla1.0.2
Priority: -- → P1
Target Milestone: --- → mozilla1.0.2
(Assignee)

Comment 7

17 years ago
Fixed checked in on branch
Keywords: edt1.0.2+, mozilla1.0.2 → fixed1.0.2
Comment on attachment 97783 [details] [diff] [review]
Patch to embedding manifests

sr=heikki
Attachment #97783 - Flags: superreview+
Comment on attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

sr=heikki
Attachment #98433 - Flags: superreview+
Comment on attachment 97783 [details] [diff] [review]
Patch to embedding manifests

r=ccarlen. I would add a comment to this item that it's optional, not required.
Attachment #97783 - Flags: review+
Comment on attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

r=ccarlen. I would add a comment to this item that it's optional, not required.
Attachment #98433 - Flags: review+

Comment 12

17 years ago
Comment on attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

a=chofmann for 1.0.2
Attachment #98433 - Flags: approval+
(Assignee)

Comment 13

17 years ago
Fix checked into trunk, with a comment in the manifests and readme.html saying
xmlextras is optional
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 14

17 years ago
Ashish please verify this on the branch and change keyword to verified1.0.2
QA Contact: mdunn → ashishbhatt

Comment 15

17 years ago
Marking as verified
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.2 → verified1.0.2
You need to log in before you can comment on or make changes to this bug.