Closed Bug 166608 Opened 22 years ago Closed 22 years ago

Add xmlextras to embedding manifests

Categories

(Core Graveyard :: Embedding: APIs, defect, P1)

Product:
Core Graveyard
Component:
Embedding: APIs
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.2

People

(Reporter: adamlock, Assigned: adamlock)

References

Details

(Keywords: topembed+, Whiteboard: [adt2] [ETA 09/12])

Attachments

(2 files)

Patch to embedding manifests
2.99 KB, patch
ccarlen
: review+
hjtoi-bugzilla
: superreview+
Details | Diff | Splinter Review
Same patch against 1.0.x branch
3.11 KB, patch
ccarlen
: review+
hjtoi-bugzilla
: superreview+
chofmann
: approval+
Details | Diff | Splinter Review 
Useful functionality for embedders to have
Keywords: topembed+

    
    

    
  
*** Bug 143342 has been marked as a duplicate of this bug. ***

    
    

    
  


  
Can I have an r/sr on these simple patches?

    
    

    
  
branch checkin approval, a=valeski@netscape.com
Keywords: edt1.0.2+

    
  
Keywords: mozilla1.2
Priority: -- → P1
Whiteboard: [adt2] [ETA 09/12]
Target Milestone: --- → mozilla1.0.2

    
    

    
  
Heikki can you give me an sr on this so I can get it into the trunk?

The readme.html already has a note about how to remove components by writing a
client-win file, but I can add something that specifically mentions XMLExtras.
Priority: P1 → --
Target Milestone: mozilla1.0.2 → ---

    
  
Blocks: 154896
Keywords: approval, 
          
            mozilla1.0.2
Priority: -- → P1
Target Milestone: --- → mozilla1.0.2

    
    

    
  
Fixed checked in on branch
Keywords: edt1.0.2+, 
          
            mozilla1.0.2 → fixed1.0.2

    
    

    
  
Comment on attachment 97783 [details] [diff] [review]
Patch to embedding manifests

sr=heikki

        Attachment #97783 -
        Flags: superreview+

    
    

    
  
Comment on attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

sr=heikki

        Attachment #98433 -
        Flags: superreview+

    
    

    
  
Comment on attachment 97783 [details] [diff] [review]
Patch to embedding manifests

r=ccarlen. I would add a comment to this item that it's optional, not required.

        Attachment #97783 -
        Flags: review+

    
    

    
  
Comment on attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

r=ccarlen. I would add a comment to this item that it's optional, not required.

        Attachment #98433 -
        Flags: review+

    
    

    
  
Comment on attachment 98433 [details] [diff] [review]
Same patch against 1.0.x branch

a=chofmann for 1.0.2

        Attachment #98433 -
        Flags: approval+

    
    

    
  
Fix checked into trunk, with a comment in the manifests and readme.html saying
xmlextras is optional
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
Ashish please verify this on the branch and change keyword to verified1.0.2
QA Contact: mdunn → ashishbhatt

    
    

    
  
Marking as verified
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.2 → verified1.0.2

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: