Closed Bug 1666083 Opened 4 years ago Closed 4 years ago

Build bustage early beta /builds/worker/checkouts/gecko/toolkit/components/antitracking/StoragePrincipalHelper.cpp:351:8: error: unused variable 'ok' [-Werror,-Wunused-variable] Gecko 82 merges to Beta on 2020-09-21

Categories

(Core :: Networking, defect, P1)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
thunderbird_esr68 --- unaffected
thunderbird_esr78 --- unaffected
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 blocking fixed

People

(Reporter: dluca, Unassigned)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Central as Early Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ce486acea039ac2f0ca791752ccc1830b44d3ffb&selectedTaskRun=Vz0VO3h1T6y6PBP-YDBxng.0

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316154790&repo=try&lineNumber=39875

 make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/parentalcontrols'
[task 2020-09-19T12:28:30.702Z] 12:28:30     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.702Z] 12:28:30     INFO -  mkdir -p '.deps/'
[task 2020-09-19T12:28:30.702Z] 12:28:30     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.703Z] 12:28:30     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.703Z] 12:28:30     INFO -  toolkit/components/protobuf/extension_set.o
[task 2020-09-19T12:28:30.704Z] 12:28:30     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_antitracking0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/antitracking -I/builds/worker/workspace/obj-build/toolkit/components/antitracking -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fno-sanitize-recover=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fsanitize-blacklist=/builds/worker/workspace/obj-build/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_antitracking0.o.pp   Unified_cpp_antitracking0.cpp
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -  In file included from Unified_cpp_antitracking0.cpp:110:
[task 2020-09-19T12:28:30.813Z] 12:28:30    ERROR -  /builds/worker/checkouts/gecko/toolkit/components/antitracking/StoragePrincipalHelper.cpp:351:8: error: unused variable 'ok' [-Werror,-Wunused-variable]
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -    bool ok = FindCharInReadable(',', iter, end);
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -         ^
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -  1 error generated.
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:723: recipe for target 'Unified_cpp_antitracking0.o' failed
[task 2020-09-19T12:28:30.813Z] 12:28:30    ERROR -  make[4]: *** [Unified_cpp_antitracking0.o] Error 1
[task 2020-09-19T12:28:30.813Z] 12:28:30     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/antitracking'
[task 2020-09-19T12:28:30.814Z] 12:28:30     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:72: recipe for target 'toolkit/components/antitracking/target-objects' failed
[task 2020-09-19T12:28:30.815Z] 12:28:30    ERROR -  make[3]: *** [toolkit/components/antitracking/target-objects] Error 2
[task 2020-09-19T12:28:30.815Z] 12:28:30     INFO -  make[3]: *** Waiting for unfinished jobs....
[task 2020-09-19T12:28:30.817Z] 12:28:30     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.817Z] 12:28:30     INFO -  toolkit/components/protobuf/generated_enum_util.o
[task 2020-09-19T12:28:30.817Z] 12:28:30     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.966Z] 12:28:30     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.972Z] 12:28:30     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o extension_set.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DHAVE_ZLIB -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/protobuf -I/builds/worker/workspace/obj-build/toolkit/components/protobuf -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fno-sanitize-recover=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fsanitize-blacklist=/builds/worker/workspace/obj-build/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Wno-ignored-qualifiers -Wno-maybe-uninitialized -Wno-return-type -Wno-sign-compare -Wno-subobject-linkage -Wno-unused-function -Wno-comma -Wno-null-conversion -Wno-unused-local-typedef -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0/unix-print -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -MD -MP -MF .deps/extension_set.o.pp   /builds/worker/checkouts/gecko/toolkit/components/protobuf/src/google/protobuf/extension_set.cc
[task 2020-09-19T12:28:30.972Z] 12:28:30     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.972Z] 12:28:30     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:30.972Z] 12:28:30     INFO -  toolkit/components/protobuf/generated_message_table_driven_lite.o
[task 2020-09-19T12:28:30.972Z] 12:28:30     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:31.018Z] 12:28:31     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
[task 2020-09-19T12:28:31.025Z] 12:28:31     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o generated_enum_util.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DHAVE_ZLIB -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/protobuf -I/builds/worker/workspace/obj-build/toolkit/components/protobuf -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fno-sanitize-recover=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fsanitize-blacklist=/builds/worker/workspace/obj-build/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Wno-ignored-qualifiers -Wno-maybe-uninitialized -Wno-return-type -Wno-sign-compare -Wno-subobject-linkage -Wno-unused-function -Wno-comma -Wno-null-conversion -Wno-unused-local-typedef -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0/unix-print -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -MD -MP -MF .deps/generated_enum_util.o.pp   /builds/worker/checkouts/gecko/toolkit/components/protobuf/src/google/protobuf/generated_enum_util.cc
[task 2020-09-19T12:28:31.027Z] 12:28:31     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/protobuf'
Flags: needinfo?(tihuang)

Looks like just an "#ifdef MOZ_DIAGNOSTIC_ASSERT_ENABLED" is required.

Thanks, I've submitted a patch to fix this in Bug 1635828.

Flags: needinfo?(tihuang)

Fixed by backout.

status-firefox82: affected → fixed
tracking-firefox82: ? → blocking
Target Milestone: --- → 82 Branch

(In reply to Julien Cristau [:jcristau] from comment #3)

Fixed by backout.

Since it's fixed, I assume we can close it?

Whiteboard: [necko-triaged]
Severity: -- → S2
Priority: -- → P1
Severity: S2 → N/A

Oops, yes.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.