1666116 - Intermittent TestAudioTrackGraph.SourceTrack | Expected: (preSilenceSamples) <= (128U + 2 * inputRate / 100), actual: 10712 vs 1010 @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:373 | test completed (time: 110ms)

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=316181119&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LxhvOvlDRMSYVFsXu1ayZg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-09-19T22:14:25.083Z] 22:14:25     INFO -  TEST-PASS | TestAudioTrackGraph.ErrorStateCrash | test completed (time: 93ms)
[task 2020-09-19T22:14:25.083Z] 22:14:25     INFO -  TEST-START | TestAudioTrackGraph.SourceTrack
[task 2020-09-19T22:14:25.083Z] 22:14:25     INFO -  [5636, CubebOperation #1] WARNING: Could not set the audio stream volume in GraphDriver.cpp: 'rv == CUBEB_OK', file /builds/worker/checkouts/gecko/dom/media/GraphDriver.cpp, line 693
[task 2020-09-19T22:14:25.138Z] 22:14:25     INFO -  [5636, CubebOperation #1] WARNING: Could not set the audio stream volume in GraphDriver.cpp: 'rv == CUBEB_OK', file /builds/worker/checkouts/gecko/dom/media/GraphDriver.cpp, line 693
[task 2020-09-19T22:14:25.193Z] 22:14:25     INFO -  PreSilence: 10712
[task 2020-09-19T22:14:25.193Z] 22:14:25  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.SourceTrack | Expected: (preSilenceSamples) <= (128U + 2 * inputRate / 100), actual: 10712 vs 1010 @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:373
[task 2020-09-19T22:14:25.193Z] 22:14:25  WARNING -  TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.SourceTrack | test completed (time: 110ms)```

Comment 1

[Intermittent Failures Robot]

2 failures in 3760 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform breakdown:

• windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-09-14&endday=2020-09-20&tree=all

Comment 2

[Intermittent Failures Robot]

3 failures in 4019 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• autoland: 2

Platform breakdown:

• windows7-32: 1
• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-09-21&endday=2020-09-27&tree=all

Comment 3

[Intermittent Failures Robot]

15 failures in 4195 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 9
• autoland: 6

Platform breakdown:

• windows10-64: 13
• windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-09-28&endday=2020-10-04&tree=all

Comment 4

[Intermittent Failures Robot]

5 failures in 4130 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 4

Platform breakdown:

• windows10-64: 3
• windows7-32: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 5

[Intermittent Failures Robot]

5 failures in 3694 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4
• mozilla-central: 1

Platform breakdown:

• windows7-32: 2
• windows10-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-10-12&endday=2020-10-18&tree=all

Comment 6

[Intermittent Failures Robot]

3 failures in 4230 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform breakdown:

• windows7-32: 2
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-10-19&endday=2020-10-25&tree=all

Comment 7

[Intermittent Failures Robot]

4 failures in 4275 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• mozilla-central: 2

Platform breakdown:

• windows10-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 8

[Intermittent Failures Robot]

2 failures in 4128 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• try: 1

Platform breakdown:

• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666116&startday=2020-11-02&endday=2020-11-08&tree=all

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1666116 - Account for fallback in NotifyWhenGraphStarted. r?padenot!

Unittests using GoFaster mode may start iterating the audio driver faster before
its fallback has completed handover to the audio callback. This causes the
preSilenceSamples check to spike and the test fails.

Waiting for the fallback to finish handing over fixes this.

To accomodate this, this patch also constifies some methods as needed to check
InIteration() when const. It also waits for audio drivers to start per the above
in TestCrossGraphTrack as that test may otherwise exhibit this bug with bug
1605314 applied.

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1666116 - Work around a static-analysis error causing bustages. r?padenot!

It stems from Result<RefPtr<MockCubeb::AudioThreadAutoUnforcer>, nsresult> being a must-use type.
It boils down to:
/builds/worker/workspace/obj-build/dist/include/mozilla/Maybe.h:259:15: note:
'union Union' is a must-use type because member 'val' is a must-use type
'detail::MaybeStorage<Result<RefPtr<MockCubeb::AudioThreadAutoUnforcer>, nsresult>, false>::NonConstT'
(aka 'Result<RefPtr<MockCubeb::AudioThreadAutoUnforcer>, nsresult>')
NonConstT val;
^

Comment 11

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1666116 - Avoid switching audio driver twice in audio-input gtests, for determinism. r?padenot!

Comment 12

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1666116 - Pre-create the fake audio thread for timing sensitive tests. r?padenot!

It has been observed on try to take a long time to start the fake audio thread.
On Mac it would regularly take around half a second. This patch mitigates that
start-up time being long by making sure the thread is already started.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06ced7ee7c2c
Account for fallback in NotifyWhenGraphStarted. r=padenot
https://hg.mozilla.org/integration/autoland/rev/3225cdc96f82
Work around a static-analysis error causing bustages. r=padenot
https://hg.mozilla.org/integration/autoland/rev/c529b6732b08
Avoid switching audio driver twice in audio-input gtests, for determinism. r=padenot
https://hg.mozilla.org/integration/autoland/rev/dba15089f5d3
Pre-create the fake audio thread for timing sensitive tests. r=padenot

Comment 14

[Narcis Beleuzu [:NarcisB]]

Backed out for GTest failures on TestAudioTrackGraph

Backout link: https://hg.mozilla.org/integration/autoland/rev/c1966d168b33b8ea005418d5564e2b414bb535a9
Log link: https://treeherder.mozilla.org/logviewer?job_id=322336552&repo=autoland&lineNumber=29579

Comment 15

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1666116 - Reduce non-determinism in CrossGraphPort gtest with the help of stream start-freezing. r?padenot!

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e2a2c13ef60
Account for fallback in NotifyWhenGraphStarted. r=padenot
https://hg.mozilla.org/integration/autoland/rev/93aef991a475
Work around a static-analysis error causing bustages. r=padenot
https://hg.mozilla.org/integration/autoland/rev/351419be5c0d
Reduce non-determinism in CrossGraphPort gtest with the help of stream start-freezing. r=padenot
https://hg.mozilla.org/integration/autoland/rev/506522ae896e
Avoid switching audio driver twice in audio-input gtests, for determinism. r=padenot
https://hg.mozilla.org/integration/autoland/rev/fedcb7e94929
Pre-create the fake audio thread for timing sensitive tests. r=padenot

Comment 17

[Cristina Coroiu [:ccoroiu]]

Backed out 21 changesets (bug 1666116, bug 1605134) for build bustage at checkouts/gecko/dom/media/gtest/WaitFor.h

Backout: https://hg.mozilla.org/integration/autoland/rev/e0e5fe5a99cd1fefff515acb5edfe0b69b8d3774

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=fedcb7e94929f38b06234eaacfb3ae5970212fa7

Failure log: https://treeherder.mozilla.org/logviewer?job_id=323041885&repo=autoland&lineNumber=10500

Comment 18

[Andreas Pehrson [:pehrsons]]

Thanks. Things have been shifted around in bug 1676365.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69bc5617b415
Account for fallback in NotifyWhenGraphStarted. r=padenot
https://hg.mozilla.org/integration/autoland/rev/15fc59a6b0d2
Work around a static-analysis error causing bustages. r=padenot
https://hg.mozilla.org/integration/autoland/rev/e45fb2b1f2a1
Reduce non-determinism in CrossGraphPort gtest with the help of stream start-freezing. r=padenot
https://hg.mozilla.org/integration/autoland/rev/29c4d6296400
Avoid switching audio driver twice in audio-input gtests, for determinism. r=padenot
https://hg.mozilla.org/integration/autoland/rev/d493fa5e5cc6
Pre-create the fake audio thread for timing sensitive tests. r=padenot

Comment 20

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/69bc5617b415
https://hg.mozilla.org/mozilla-central/rev/15fc59a6b0d2
https://hg.mozilla.org/mozilla-central/rev/e45fb2b1f2a1
https://hg.mozilla.org/mozilla-central/rev/29c4d6296400
https://hg.mozilla.org/mozilla-central/rev/d493fa5e5cc6