1666172 - Upgrade to Node 10.22.1 (security release)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

+++ This bug was initially created as a clone of Bug #1641863 +++

https://nodejs.org/en/blog/vulnerability/september-2020-security-releases/

The latest upgrade of this sort was done by :Mardak in bug 1641863. This patch should be analogous and nearly identical.

A reasonable argument could be made that this patch should be uplifted to ESR 78 as well.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1666172 - Update node to 10.22.1.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26394defe88f
Update node to 10.22.1. CLOSED TREE

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/26394defe88f

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

This has resurrected bug 1651542.

Perma failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318074778&repo=autoland&lineNumber=440

Tested a backout on try to confirm: https://treeherder.mozilla.org/#/jobs?repo=try&revision=059dd8096f25652eed3ec94e689114a3cf5d146c&selectedTaskRun=QaqnEetRQ9S5pZB3guLApw.0

Comment 5

[Mark Banner (:standard8)]

(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #4)

This has resurrected bug 1651542.

As far as I know Node isn't directly related to those tests, and from reading that bug it appears it is something to do with the docker image generation. So at the moment, it looks like it is an issue with that test harness.

I've asked Henrik to take another look at that bug.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Puppeteer is a node.js library so there could be indeed a relationship between this update and the newly occurred failures. Also see the try build with the node.js upgrade backed-out. It just works fine and the puppeteer job is no longer failing.

Is there a way to just retrigger the ub18-test docker image creation, and check if that also fixes the problem? As it looks like I can't just do it via the Treeherder UI.

Comment 7

[Mark Banner (:standard8)]

Here's the release notes for the two node releases we picked up, I don't see anything too major in those though:

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#2020-09-15-version-10221-dubnium-lts-bethgriggs
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#2020-07-21-version-10220-dubnium-lts-bethgriggs-prepared-by-richardlau

There's been a bunch of changes on puppeteer, but I don't see anything particularly relevant to Node. However, I've just done a try push with the latest 5.3.1 version to see if that helps: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a6a270874b00f8e5b04a446175293a99499ca1b

If it doesn't, then we're going to have to make a call about backing out, and we'll need to have someone who knows puppeteer take over looking at this.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The failure is still present even with the new Puppeteer release. So given that nothing in node.js seem to have been changed here, lets figure out a solution on bug 1651542.

Also note that recently more pup jobs on autoland are passing. It gives the feeling that something is wrong with the test machines or the environment: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=pup&fromchange=d368b4f167322c1b8e809f13f94e807af6009b64

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

New ub18-test test has been requested for https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=ub18-test&revision=34caac97f7fa11d53c6bc66cf82afb4e62a331f2

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #9)

New ub18-test test has been requested for https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=ub18-test&revision=34caac97f7fa11d53c6bc66cf82afb4e62a331f2

Thanks! That actually fixed the failures of the puppeteer jobs:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=pup&fromchange=34caac97f7fa11d53c6bc66cf82afb4e62a331f2