16662 - TerminateProcess & TerminateThread

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect, P3)

Description

[cparks]

I thought you would be interested in knowing that your software has made the
Developer's Terminate Process & Terminate Thread Black List.

Comment 1

[Sean Richardson]

This is could be considered INVALID: the blacklist refers only to Released
software using TerminateProcess & TerminateThread that leak memory because
of their use of these two calls; in this case to Communicator.

On the other hand, perhaps this could be kept as a QA-tracking bug and given
a Target Milestone of 16 or so as a checkpoint to make sure that these
calls are removed prior to shipping.

(It is possible that XP threading code could call these indirectly through
an MFC dll for Win32 builds)

Marking M16 and REMIND; go ahead and INVALIDATE if this makes no sense.

Comment 2

[rpotts (gone)]

This is really an NSPR bug, since it deals with calls to the Win32 threading
API...  I'm cc'ing larryh to let him know.

-- rick

Comment 3

[leger]

Resetting QA contact from leger.

Comment 4

[Sean Richardson]

http://lxr.mozilla.org/nspr/search?string=TerminatePro%2CTerminateThr&regexp=on
shows exactly one use of TerminateProcess:

http://lxr.mozilla.org/nspr/source/nsprpub/pr/src/md/windows/ntmisc.c#553
in _PR_KillWindowsProcess 
( http://lxr.mozilla.org/nspr/ident?i=_PR_KillWindowsProcess )

Following that trail, there does not seem to be any Seamonkey code that calls 
_PR_KillWindowsProcess, so from the point of view of not using
the TerminateProcess & TerminateThread  calls, Mozilla looks good.

Comment 5

[larryh (gone)]

adding Wan-Teh to the cc list.

Comment 6

[larryh (gone)]

We concur with comments by Sean Richardson.

NSPR does not provide a mechanism to kill threads. Killing a thread is (IMNSHO) 
is a Bad-Thing. NSPR does provide a PR_KillProcess() function.

NSPR does not think this is a bug.

Comment 7

[Blake Ross]

reopening and marking Future...

Comment 8

[larryh (gone)]

Kill Process and Kill Thread is bad programming practice.
Marking WontFix.

Comment 9

[Hixie (not reading bugmail)]

Moving all threading bugs to XPCOM. See bug 160356.