Open Bug 1666224 Opened 5 years ago Updated 4 years ago

wrong isOutgoing function

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Product:
Calendar
Component:
E-mail based Scheduling (iTIP/iMIP)
Type:
defect

Tracking

(Not tracked)

Status:
UNCONFIRMED

People

(Reporter: cardbook.thunderbird, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Hi

I think the function isOutgoing (here : https://searchfox.org/comm-esr78/source/calendar/lightning/content/imip-bar.js#231) is wrong...

instead of line 136 :
let isSentFolder = aMsgHdr.folder && aMsgHdr.folder.flags & Ci.nsMsgFolderFlags.SentMail;

there should be something like this, no ? :
let outgoing_folder_flags = Components.interfaces.nsMsgFolderFlags.SentMail | Components.interfaces.nsMsgFolderFlags.Drafts | Components.interfaces.nsMsgFolderFlags.Queue | Components.interfaces.nsMsgFolderFlags.Templates;
let isSentFolder = aMsgHdr.folder && aMsgHdr.folder.isSpecialFolder(outgoing_folder_flags, true);

(similar to function here : https://searchfox.org/comm-esr78/source/mail/base/content/mailWidgets.js#672)

Actual results:

Expected results:

Component: Untriaged → Mail Window Front End

Submit a patch? :)

Component: Mail Window Front End → E-mail based Scheduling (iTIP/iMIP)
Product: Thunderbird → Calendar
Version: 78 → unspecified

Hi Magnus

:)

I'm not sure that the function here : https://searchfox.org/comm-esr78/source/mail/base/content/mailWidgets.js#672 is also correct... I'm testing this and I'm not happy with none of these two isOutgoing functions...

Well that looks basically like your suggestion :)

Anything actionable in this bug?

You need to log in before you can comment on or make changes to this bug.