1666275 - [wpt-sync] Sync PR 25649 - sensors: Only call test_driver.set_permission from the top-level window.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25649 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25649
Details from upstream follow.

b'Raphael Kubo da Costa <[e-mail]>' wrote:

sensors: Only call test_driver.set_permission from the top-level window.

testdriver.js' documentation says "presently, testdriver.js only works
in the top-level test browsing context (and not therefore in any frame
or window opened from it".

If we do not restrict the set_permission() call here, the call to
initialize_generic_sensor_tests() in
generic-sensor/resources/iframe_sensor_handler.html will time out
waiting for it to complete when running the iframe tests outside the
Chromium CI (i.e. in wpt.fyi or with "wpt run").

Change-Id: I522a5ebacb7da9e35bbe2ea3564d3288a34c653b

Reviewed-on: https://chromium-review.googlesource.com/2421671
WPT-Export-Revision: f4e7c9e372729cfad071d4350a1a722bec228243

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbd04fc116da574fccc6f9cdecfce84c1571bcbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a4b6db38672
[wpt PR 25649] - sensors: Only call test_driver.set_permission from the top-level window., a=testonly

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2a4b6db38672