Closed Bug 1666326 Opened 5 years ago Closed 5 years ago

Always use the BrowsingContext's history id for nsIDocShell's historyID

Categories

(Core :: DOM: Navigation, defect)

defect

Tracking

()

RESOLVED FIXED
83 Branch
Fission Milestone M6b
Tracking Status
firefox83 --- fixed

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(2 files)

Currently we store the history ID both in a member on nsDocShell and in a synced field on BrowsingContext. When we load from history and session history in the parent is enabled we end up updating the BrowsingContext's field, but not the nsDocShell's. Removing the nsDocShell's field seems like the sanest thing to do.

Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89fda771b7c8 Remove nsDocShell::mHistoryID and always use the BrowsingContext's HistoryID synced field. r=farre https://hg.mozilla.org/integration/autoland/rev/14d5592e235a Fix docshell/test/navigation/test_bug1375833.html for session history in the parent. r=farre
Fission Milestone: --- → M6b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: