Closed Bug 1666358 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25662 - [LayoutNG] Multicol baseline propagation support.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
83 Branch
Tracking Flags:
Tracking Status
firefox83 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25662 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25662
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

[LayoutNG] Multicol baseline propagation support.

Spec: https://drafts.csswg.org/css-align/#baseline-export

The "first baseline set" of a multicol container is the baseline of the
first line box in the first column (i,e, ignore all other columns), or
the baseline of the first line box in the first column spanner that has
such a thing, whichever comes first.

Multicol containers have no "last baseline set", and, as such,
fast/multicol/inline-block-baseline.html is invalid, since an
inline-block aligns with the "last baseline set". Remove the test, and
replace it with its antithesis, baseline-008.html in
wpt/css/css-multicol/.

And added a bunch of tests, since this feature seemed to have no
coverage, apart from the deleted test in fast/multicol/.

Bug: 829028
Change-Id: I954de9618fde87dbfa37292786ca6a2dcce9fa1f
Reviewed-on: https://chromium-review.googlesource.com/2421462
WPT-Export-Revision: cac666384f3235acbfcfff10024e7277638f9fe6

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests

Status Summary

Firefox

PASS: 8
FAIL: 1

Chrome

PASS: 6
FAIL: 3

Safari

PASS: 4
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-multicol/baseline-007.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/413e038a0967
[wpt PR 25662] - [LayoutNG] Multicol baseline propagation support., a=testonly
https://hg.mozilla.org/integration/autoland/rev/f9e0b3313ec2
[wpt PR 25662] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/413e038a0967
https://hg.mozilla.org/mozilla-central/rev/f9e0b3313ec2

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.