1666481 - Perma SM TEST-UNEXPECTED-FAIL | wasm/jsapi/memory/constructor-types.tentative.any.js | (args: "") [0.1 s] when Gecko 83 merges to Beta on 2020-10-19

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect)

Description

[Atila Butkovits]

[Tracking Requested - why for this release]:

Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=cf2688dfff47d7822f5b1723cfdf51aff836b6a9&searchStr=spidermonkey&selectedTaskRun=ZtFYhFyhSECyDNuHcUbZ4Q.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316359447&repo=try&lineNumber=88761

[task 2020-09-22T11:14:55.295Z] ## wasm/jsapi/memory/constructor-types.tentative.any.js: rc = 0, run time = 0.145586
[task 2020-09-22T11:14:55.295Z] 
[task 2020-09-22T11:14:55.296Z] Harness status: OK (Reported by harness: None)
[task 2020-09-22T11:14:55.297Z] TEST-UNEXPECTED-FAIL | wasm/jsapi/memory/constructor-types.tentative.any.js | (args: "") [0.1 s]
[task 2020-09-22T11:14:55.313Z] TEST-PASS | wasm/jsapi/memory/toString.any.js | (args: "") [0.1 s]
[task 2020-09-22T11:14:55.319Z] TEST-PASS | wasm/jsapi/interface.any.js | (args: "") [0.2 s]
[task 2020-09-22T11:14:55.325Z] ## wasm/jsapi/memory/constructor.any.js: rc = 0, run time = 0.172824
[task 2020-09-22T11:14:55.325Z] 
[task 2020-09-22T11:14:55.325Z] Harness status: OK (Reported by harness: None)```
:jtallon could you take a look?

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=696d23d5bd027704b6a7a42650144028969ea2b0

Comment 1

[Lars T Hansen [:lth]]

Jessica, can you look into this? This may be caused by the js-types API only being enabled on Nightly but tests being run also on beta and release. Tests may need to be adapted.

Comment 2

[Jessica (ooo; ni? to wingo)]

I'm looking into it now

Comment 3

[Jessica (ooo; ni? to wingo)]

Attachment: Bug 1666481 - Fix broken wasm web platform test

This addresses a problem for the failing tests surrounding WASM Memory
and table constructors. The type reflection feature added a minimum
parameter which is enabled on nightly but not beta and relese. This
fixes the expectations so they it's expected they fail in those
situations.

It also addresses a problem in a failing test which always passed due to
a missing new keyword.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9d65fd50034
Fix broken wasm web platform test r=lth

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25757 for changes under testing/web-platform/tests

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f9d65fd50034

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=a8213d07f925fa23de8539a12380475f0abdb867