1666499 - Perma CDP TEST-UNEXPECTED-PASS | Page Page.close should *not* run beforeunload by default (page.spec.ts) | expected TIMEOUT

Status: RESOLVED WONTFIX

(Remote Protocol :: Agent, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=316365645&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W77dGEcQT5K2pS1lOvvS8A/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-09-22T11:54:13.389Z] PID 200 | ["test-start",{"title":"should *not* run beforeunload by default","fullTitle":"Page Page.close should *not* run beforeunload by default","file":"/builds/worker/checkouts/gecko/remote/test/puppeteer/test/page.spec.ts","currentRetry":0}]

[task 2020-09-22T11:54:14.153Z] PID 200 | JavaScript error: chrome://remote/content/domains/parent/page/DialogHandler.jsm, line 103: TypeError: can't access property "listPrompts", this._browser.tabModalPromptBox is undefined
[task 2020-09-22T11:54:15.155Z] PID 200 | 1600775655154	RemoteAgent	TRACE	<-(connection {73cdd381-1b81-4e7b-be4a-3dad2264caad}) {"method":"Target.targetDestroyed","params":{"targetId":"fa5fd86d-089a-4901-9824-4d4f64dfa044"}}
[task 2020-09-22T11:54:15.158Z] PID 200 | 1600775655157	RemoteAgent	TRACE	<-(connection {73cdd381-1b81-4e7b-be4a-3dad2264caad}) {"id":159}
[task 2020-09-22T11:54:15.159Z] TEST-UNEXPECTED-PASS | Page Page.close should *not* run beforeunload by default (page.spec.ts) | expected TIMEOUT
[task 2020-09-22T11:54:15.159Z] TEST-INFO expected TIMEOUT | took 1769ms
[task 2020-09-22T11:54:15.159Z] PID 200 | ["pass",{"title":"should *not* run beforeunload by default","fullTitle":"Page Page.close should *not* run beforeunload by default","file":"/builds/worker/checkouts/gecko/remote/test/puppeteer/test/page.spec.ts","duration":1481,"currentRetry":0}]
[task 2020-09-22T11:54:15.165Z] PID 200 | 1600775655165	RemoteAgent	TRACE	(connection {73cdd381-1b81-4e7b-be4a-3dad2264caad})-> {"method":"Target.disposeBrowserContext","params":{"browserContextId":9},"id":160}
[task 2020-09-22T11:54:15.173Z] PID 200 | 1600775655172	RemoteAgent	TRACE	<-(connection {73cdd381-1b81-4e7b-be4a-3dad2264caad}) {"method":"Target.targetDestroyed","params":{"targetId":"2dac6cbb-4066-44b7-af69-44984345170f"}}
[task 2020-09-22T11:54:15.180Z] PID 200 | 1600775655178	RemoteAgent	TRACE	<-(connection {73cdd381-1b81-4e7b-be4a-3dad2264caad}) {"id":160}```

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I did some retriggers for the last days on central. Looks like its a new regression probably caused by the sub dialog.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Changed from expected timeout to unexpected pass for this mozilla-central merge:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=pup&revision=fa0bf905d4cb944368ddf8fbe38cca4107692fd4

So most likely bug 1655866 fixed it.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1666499 - [remote] Updated expectation status for test "Page.close should *not* run beforeunload by default"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35066da8f3c3
[remote] Updated expectation status for test "Page.close should *not* run beforeunload by default" r=remote-protocol-reviewers,maja_zf

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/35066da8f3c3

Comment 6

[Intermittent Failures Robot]

6 failures in 4019 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6

Platform breakdown:

• linux1804-64: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1666499&startday=2020-09-21&endday=2020-09-27&tree=all

Comment 7

[Chris Peterson [:cpeterson]]

Clearing Fission Milestone "?" flag for this bug that has already been resolved.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The unexpected pass was by accident here. It was actually a regression that was fixed by bug 1666670 now.

Please back out so that we can get bug 1668728 fixed.

Comment 9

[Razvan Maries]

Backed out from autoland: https://hg.mozilla.org/integration/autoland/rev/e4ba188f7121bf980c0d9a31e353295beb1cc118

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the backout the test is marked as expected fail again. So lets keep it open until we have figured out what's wrong.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/e4ba188f7121

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is a CDP failure and marked as SKIP at the moment. We are not going to investigate and fix this.