Closed Bug 1666520 Opened 8 months ago Closed 8 months ago

hg push fails in firefoxtree prepushoutgoinghook

Categories

(Developer Services :: Mercurial: firefoxtree, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tjr, Assigned: sheehan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I've run ./mach bootstrap.

hg --version > Mercurial Distributed SCM (version 5.1.1)

hg log of version-control-tools
changeset:   7610:d200c669f83a
bookmark:    @
tag:         tip
user:        Peter Van der Beken <peterv@propagandism.org>
date:        Mon Sep 21 20:41:15 2020 +0000
summary:     Bug 1666342 - Add Andrew Sutherland to the WebIDL hook. r=sheehan
   File "/usr/local/Cellar/mercurial/5.1.1_2/lib/python2.7/site-packages/mercurial/util.py", line 3129, in __call__
    results.append(hook(*args))
  File "/Users/tritter/.mozbuild/version-control-tools/hgext/firefoxtree/__init__.py", line 343, in prepushoutgoinghook
    if len(outgoing.ancestorsof) > 1:
AttributeError: 'outgoing' object has no attribute 'ancestorsof'
Component: General → Bootstrap Configuration

dir(outgoing) shows ['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__', '__hash__', '__init__', '__module__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_common', '_computecommonmissing', '_missing', '_revlog', 'common', 'commonheads', 'excluded', 'missing', 'missingheads']

Regressed by 60d9824ff108c6.

Forgot to add a compatibility shim for older versions of hg.

Assignee: nobody → sheehan

missingheads was renamed to ancestorsof in newer versions of Mercurial,
but the patch from 60d9824ff108c6 does not take the older variable name into
account. Add a check for the attribute so both variable names work in the
prepushoutgoinghook.

Pushed by cosheehan@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1cec2d7c777b
firefoxtree: add compatibility branch so older versions of Mercurial still work r=zeid

Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Component: Bootstrap Configuration → Mercurial: mozext
Product: Firefox Build System → Developer Services
Component: Mercurial: mozext → Mercurial: firefoxtree
You need to log in before you can comment on or make changes to this bug.