Closed Bug 1666550 Opened 4 years ago Closed 3 years ago

Update clang tools (tidy, format) to 11.0

Categories

(Firefox Build System :: Toolchains, task, P3)

task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: Sylvestre, Assigned: andi)

References

Details

(Keywords: in-triage)

Attachments

(2 files)

clang-format has a bug (see bug 1666129) which seems to be fixed by commenting the line here:
https://reviews.llvm.org/D79388#inline-815942

clang-tidy 11 has probably new checkers that we could enable

I had already worked through 90% of the json-wrangling for clang-trunk work, this can be used as a starting point: https://hg.mozilla.org/try/rev/96b1ff6140680089c56e957e42e1fa370b4a5884

Severity: -- → S3
Priority: -- → P3
Keywords: in-triage
Assignee: nobody → rstewart

I'll wait and see if we need a patch for that regression or if it gets fixed in the release.

Looks like the final release does have that patch, so we should be good to go?

No, clang-format is still broken.
I am working on a patch

Thanks.

here is the patch which should be applied to the 11 branch to fix the clang-format issue.

Andi, could you please take care of the upgrade+testing to clang-11 ?

Assignee: rstewart → bpostelnicu
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08bdfc1659da
Update `clang-tools` to `clang-11`. r=dmajor
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: