Update clang tools (tidy, format) to 11.0
Categories
(Firefox Build System :: Toolchains, task, P3)
Tracking
(firefox85 fixed)
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: andi)
References
Details
(Keywords: in-triage)
Attachments
(2 files)
5.56 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
clang-format has a bug (see bug 1666129) which seems to be fixed by commenting the line here:
https://reviews.llvm.org/D79388#inline-815942
clang-tidy 11 has probably new checkers that we could enable
I had already worked through 90% of the json-wrangling for clang-trunk work, this can be used as a starting point: https://hg.mozilla.org/try/rev/96b1ff6140680089c56e957e42e1fa370b4a5884
Updated•4 years ago
|
Updated•4 years ago
|
Comment 2•4 years ago
|
||
I'll wait and see if we need a patch for that regression or if it gets fixed in the release.
Comment 4•4 years ago
|
||
Looks like the final release does have that patch, so we should be good to go?
Reporter | ||
Comment 5•4 years ago
|
||
No, clang-format is still broken.
I am working on a patch
Comment 6•4 years ago
|
||
Thanks.
Reporter | ||
Comment 7•4 years ago
|
||
here is the patch which should be applied to the 11 branch to fix the clang-format issue.
Reporter | ||
Comment 8•4 years ago
|
||
Andi, could you please take care of the upgrade+testing to clang-11 ?
Assignee | ||
Comment 9•3 years ago
|
||
Comment 10•3 years ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08bdfc1659da Update `clang-tools` to `clang-11`. r=dmajor
Comment 11•3 years ago
|
||
bugherder |
Description
•