1666604 - MPS CI to detect and block incompatible schemas changes

Status: RESOLVED DUPLICATE of bug 1666608

(Data Platform and Tools :: General, task, P2)

Description

[Wesley Dawson [:whd]]

https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/617 and https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/619 are examples.

This should probably be something that can be overridden on a case-by-case basis, but the default should be to (automatically) disallow such changes. We could also make a policy decision that such changes are never allowed, even when they haven't propagated to staging and production environments, or to only allow them if generated-schemas hasn't been updated yet.

Comment 1

[Wesley Dawson [:whd]]

The approach we ended up taking was to implement bug #1666608 first, which for the purposes of pipeline deployment automation safety is sufficient. This bug might still be worth doing, or perhaps was already done. If implemented, it would probably add another step to undo for the recently filed bug #1682627.

:amiyaguchi, can you weigh in on whether this is still worth doing?

Comment 2

[Anthony Miyaguchi [:amiyaguchi]]

Yes, this is still worth doing. I recently reviewed an involved schema that introduced several schema incompatible (also permanent but undesirable) changes to MPS, so this is still worth doing.

Comment 3

[William Lachance (:wlach)]

This was implemented with bug 1666608, bug 1682627 augmented it so we can override if necessary (as described in comment 1).

Note that this isn't working in all cases due to bug 1746018, but that's a defect we can track separately.