Closed
Bug 1666708
Opened 4 years ago
Closed 4 years ago
MarkerCategory only needs to store the `CategoryPair`, not the super-category
Categories
(Core :: Gecko Profiler, task, P2)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
83 Branch
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
MarkerCategory currently stored both the "category pair" (a number that captures both the super- and sub-category) and the super-category.
But only the category pair is really needed when adding a marker. This will save 1 byte per marker in the buffer, and it will also make it easier to convert legacy APIs in the short term.
|
Assignee | |
Comment 1•4 years ago
|
||
This saves 1 byte when serializing each marker.
Also it will be easier to use it in legacy code that only knows about the category pair.
Added unit tests for the whole of MarkerCategory.
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a88cc1834c4d Only store category pair in MarkerCategory - r=gregtatum
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox83:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•